Added information about the new form(), form_start() and form_end() helpers #2092
Conversation
|
The |
|
@wouterj I suggest that this change be made in a separate PR. |
|
@bschussek I meant the |
| @@ -613,12 +605,12 @@ of code. Of course, you'll usually need much more flexibility when rendering: | |||
| {{ form_rest(form) }} | |||
|
|
|||
| <input type="submit" /> | |||
| </form> | |||
| {{ form_end() }} | |||
There was a problem hiding this comment.
should be form_end(form) and the form_rest would not be needed anymore.
I don't understand. As far as I see all the arguments in the Twig reference are named "variables", not "vars". Also I fail to see how Twig could take advantage of named arguments here. If you check FormExtension.php, there is no specification of the function arguments. |
|
Indeed, as you are using a custom node, the named arguments will not be supported unless you add it in your custom node |
|
Consequently I think this change can be postponed to when this will be supported. Right now, the Twig reference is consistent: All methods indicate the parameter |
|
Rebased on master |
This PR was merged into the master branch. Discussion ---------- [2.3] [Form] Implemented form processors Bug fix: no Feature addition: yes Backwards compatibility break: no Symfony2 tests pass: yes Fixes the following tickets: partially #5493 Todo: - License of the code: MIT Documentation PR: symfony/symfony-docs#2092 Commits ------- 11fee06 [TwigBridge] Removed duplicate entries from the CHANGELOG 68f360c [Form] Moved upgrade nodes to UPGRADE-3.0 01b71a4 [Form] Removed trigger_error() for deprecations as of 3.0 81f8c67 [Form] Implemented form processors 0ea75db [Form] Improved FormRenderer::renderBlock() to be usable outside of form blocks
|
I added information about request handlers now. |
|
This can be merged. |
[WCM] Added information about the new form(), form_start() and form_end() helpers
|
Hey Mr Bernhard! I've merged this in with minor tweaks at sha: adf8989. I've kept a reference to the old "bind" method so that if people look for it, they'll find the explanation of why it's changed. You did a nice job covering all the different areas that needed to be updated, so I think we're in great shape. If you see any tweaks that need to be made to my tweaks, let me know. Thanks! |
|
Thank you so much Ryan! :) 👍 |
This PR was merged into the master branch. Discussion ---------- [Form] Renamed form processors to request handlers | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | symfony/symfony-docs#2092 Commits ------- ae7c378 [Form] Renamed form processors to request handlers
Documentation for symfony/symfony#6522 and symfony/symfony#7732.