[WCM] Renamed TypeTestCase namespace #2500
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
wouterj
commented
Apr 13, 2013
| Q | A |
|---|---|
| Doc fix? | yes |
| New docs? | yes ( symfony/symfony#7659 ) |
| Applies to | 2.3+ |
| Fixed tickets | - |
2 tasks
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Apr 19, 2013
This PR was merged into the master branch. Discussion ---------- [Form] Moved TypeTestCase to the Test namespace | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #7175 | License | MIT | Doc PR | symfony/symfony-docs#2500 Todo: - [x] Make a Doc PR - [x] Update the changelog and UPGRADE-3.md files As discussed in #7175, since this class is documented as a practise to test your form types, it's good to move it to the `Test` namespace. I am not sure about the deprecation, I thought things deprecated in 2.3 are removed in 3.0. Also, I think we shouldn't trigger a E_USER_DEPRECATED message. Please correct me if I'm wrong, it's my first PR for the core code. Commits ------- 8da6129 Moved FormIntegrationTestCase and FormPerformanceTestCase to the Test namespace e46f841 Moved TypeTestCase to it's own namespace
|
@weaverryan this can be merged |
weaverryan
added a commit
that referenced
this pull request
May 3, 2013
[WCM] Renamed TypeTestCase namespace
|
Nice job Wouter! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.