Skip to content

Fixing wrong variable #8015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fixing wrong variable #8015

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f8670ef
Fixing wrong variable
hthtung90 Jun 10, 2017
5d57546
Update unit_testing.rst
hthtung90 Jun 10, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions form/unit_testing.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,10 +185,10 @@ allows you to return a list of extensions to register::

protected function getExtensions()
{
$this->validator = $this->createMock(ValidatorInterface::class);
$validator = $this->createMock(ValidatorInterface::class);
// use getMock() on PHPUnit 5.3 or below
// $this->validator = $this->getMock(ValidatorInterface::class);
$this->validator
// $validator = $this->getMock(ValidatorInterface::class);
$validator
->method('validate')
->will($this->returnValue(new ConstraintViolationList()));
$validator
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be better to change the other spots back to how they were before, and fix this line to be $this->validator. They are definitely inconsistent (and should be fixed), but there is some value on setting it on a property (your tests can further configure the $this->validator mock.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, luckily we already have a pull request suggesting exactly this change (see #8013). So this will be fixed soon. That's why I'm gonna close here. But thank you for making us aware of this issue @hthtung90. Looking forward to see you soon again with some other changes. :)

Expand Down