chore: fix nx usage with lifecycle scripts across all projects
#10765
+370
−385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, @aryaemami59! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
View your CI Pipeline Execution ↗ for commit 1aee400.
☁️ Nx Cloud last updated this comment at |
5663aba to
79768d4
Compare
9d8fec3 to
2f16d41
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10765 +/- ##
=======================================
Coverage 90.83% 90.83%
=======================================
Files 497 497
Lines 50279 50279
Branches 8297 8297
=======================================
Hits 45672 45672
Misses 4592 4592
Partials 15 15
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
2f16d41 to
abd45dc
Compare
3 tasks
e2dc2a7 to
a00d190
Compare
3 tasks
719098a to
2d95a14
Compare
…t-eslint into chore/fix-life-cycle-scripts
…t-eslint into chore/fix-life-cycle-scripts
…t-eslint into chore/fix-life-cycle-scripts
…t-eslint into chore/fix-life-cycle-scripts
…t-eslint into chore/fix-life-cycle-scripts
…t-eslint into chore/fix-life-cycle-scripts
…t-eslint into chore/fix-life-cycle-scripts
…t-eslint into chore/fix-life-cycle-scripts
…t-eslint into chore/fix-life-cycle-scripts
…t-eslint into chore/fix-life-cycle-scripts
…t-eslint into chore/fix-life-cycle-scripts
…t-eslint into chore/fix-life-cycle-scripts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
jesttovitest#10679 (comment)Overview
EDIT BY @kirkwaiblinger:
This PR enforces dependencies such that
git clean -xfd && SKIP_POSTINSTALL_BUILD=true yarn && yarn testwill succeed. Previously it did not succeed since some of the test tasks apparently had undeclared dependencies on build tasks.