-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
test(type-utils): add basic tests for isTypeReadonly #4416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(type-utils): add basic tests for isTypeReadonly #4416
Conversation
Thanks for the PR, @RebeccaStevens! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
❌ Deploy Preview for typescript-eslint failed. 🔨 Explore the source changes: c7051e1 🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/61dd6ee114e55d0007cccfcf |
Codecov Report
@@ Coverage Diff @@
## main #4416 +/- ##
==========================================
+ Coverage 94.26% 94.61% +0.34%
==========================================
Files 169 147 -22
Lines 9440 7841 -1599
Branches 2940 2507 -433
==========================================
- Hits 8899 7419 -1480
+ Misses 321 233 -88
+ Partials 220 189 -31
Flags with carried forward coverage won't be shown. Click here to find out more. |
ca7410e
to
a137c76
Compare
a137c76
to
b4c8d33
Compare
b4c8d33
to
bb209f4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks so much for adding this!
…nt#4416) * fix(type-utils): make isTypeReadonly's options param optional fix typescript-eslint#4410 * test(type-utils): add basic tests for isTypeReadonly
PR Checklist
Overview
Add basic tests for
isTypeReadonly
.Note: this PR is the base of #4417, #4419,#4421 and #4429