fix(typescript-estree): wrap import = declaration in an export node #5885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, @JoshuaKGoldberg! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
JoshuaKGoldberg
commented
Oct 25, 2022
...eclaration/TSImportEqualsDeclaration/fixtures/entity-name-many/snapshots/1-TSESTree-AST.shot
Show resolved
Hide resolved
…pescript-eslint#5036) * refactor(utils)!: removed `TRuleListener` generic from the `createRule` * refactor!: removed `TRuleListener` generic from the `CLIEngine` and `RuleCreateFunction` * chore: document and refactor 'extra' to 'parserSettings' (typescript-eslint#5834) * chore(website): fix renamed Sponsorship docs link (typescript-eslint#5882) * docs: Mention wide globs performance implications in monorepos docs and parser README (typescript-eslint#5864) * docs: Mention wide globs performance implications in monorepos docs and parser readme * Update docs/linting/typed-linting/MONOREPOS.md Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com> Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com> Co-authored-by: Adnan Hashmi <56730784+adnanhashmi09@users.noreply.github.com>
…ipt-eslint#3076) * feat: update TSImportType node * fix: update visitor keys * chore: document and refactor 'extra' to 'parserSettings' (typescript-eslint#5834) * chore(website): fix renamed Sponsorship docs link (typescript-eslint#5882) * docs: Mention wide globs performance implications in monorepos docs and parser README (typescript-eslint#5864) * docs: Mention wide globs performance implications in monorepos docs and parser readme * Update docs/linting/typed-linting/MONOREPOS.md Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com> Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com> Co-authored-by: Adnan Hashmi <56730784+adnanhashmi09@users.noreply.github.com>
* feat(scope-manager): ignore ECMA version * chore: document and refactor 'extra' to 'parserSettings' (typescript-eslint#5834) * chore(website): fix renamed Sponsorship docs link (typescript-eslint#5882) * Remove much more * Fix WebLinter lint * docs: Mention wide globs performance implications in monorepos docs and parser README (typescript-eslint#5864) * docs: Mention wide globs performance implications in monorepos docs and parser readme * Update docs/linting/typed-linting/MONOREPOS.md Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com> * chore: add auto-canary release for v6 (typescript-eslint#5883) Co-authored-by: Adnan Hashmi <56730784+adnanhashmi09@users.noreply.github.com>
…TSInterfaceDeclaration and TSModuleDeclaration (typescript-eslint#4863) * chore: remove invalid properties from ast nodes * chore: remove invalid code in scope-manager and typescript-estree * chore: re-write snapshots that were using invalid properties * feat: remove modifiers union from ast types Co-authored-by: Juan García <juank1809@gmail.com> Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>
* chore(utils)\!: remove (ts-)eslint-scope types * Remove eslint-scope dep * More file deletions
JoshuaKGoldberg
commented
Oct 26, 2022
...ation/TSImportEqualsDeclaration/fixtures/entity-name-many/snapshots/5-AST-Alignment-AST.shot
Show resolved
Hide resolved
2 tasks
This reverts commit b331c98.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## v6 #5885 +/- ##
=======================================
Coverage 91.87% 91.87%
=======================================
Files 359 359
Lines 12400 12400
Branches 3653 3653
=======================================
Hits 11393 11393
Misses 703 703
Partials 304 304
Flags with carried forward coverage won't be shown. Click here to find out more.
|
JoshuaKGoldberg
commented
Dec 16, 2022
|
I think this needs a rebase before merging? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
Removes AST property and changes AST structure
PR Checklist
TSImportEqualsDeclarationshould be wrapped in anExportNamedDeclarationinstead of having.isExport = true#4130Overview
A note from our pairing: it's fine to create as many (multiple) nodes as we like from one original node.
Co-authored-by: Brad Zacher brad.zacher@gmail.com