Skip to content

feat: support ESLint v9 #9002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 30 commits into from
May 12, 2024
Merged

feat: support ESLint v9 #9002

merged 30 commits into from
May 12, 2024

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Apr 26, 2024 •
edited
Loading

👉 NOTE: This is into our v8 branch. Once it's merged, it'll only be included in our v8 versions.

PR Checklist

Overview

Keeps us on ESLint v8 internally, but adds v9 to the supported version ranges. Adds a CI check that yarn add eslint@9; yarn test passes.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as draft April 26, 2024 13:40
@netlify Netlify
Copy link

netlify bot commented Apr 26, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit ee1d91c
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/663ce10214bbb100085ba99f
😎 Deploy Preview https://deploy-preview-9002--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 99 (🟢 up 3 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Apr 26, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit ee1d91c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 32 targets

Sent with 💌 from NxCloud.

@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Apr 26, 2024
Merged
3 tasks
@jefflee-figma jefflee-figma mentioned this pull request Apr 26, 2024
Open
bradzacher
bradzacher reviewed Apr 27, 2024
View reviewed changes
@bradzacher bradzacher mentioned this pull request Apr 27, 2024
Closed
3 tasks
@MattiasBuelens MattiasBuelens mentioned this pull request Apr 28, 2024
Closed
This was referenced Apr 28, 2024
Closed
Merged
JoshuaKGoldberg
JoshuaKGoldberg commented Apr 28, 2024
View reviewed changes
@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review April 30, 2024 05:05
@JoshuaKGoldberg JoshuaKGoldberg requested review from bradzacher and a team April 30, 2024 05:05
@RobinTail RobinTail mentioned this pull request Apr 30, 2024
Closed
@JoCa96 JoCa96 mentioned this pull request Apr 30, 2024
Closed
auvred
auvred approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@auvred auvred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! LGTM 🏆

bradzacher
bradzacher reviewed May 3, 2024
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: do we really want to do the bump to v9 if it completely breaks our lint setup like this?
would we be better served by instead just adding a decent integration test which runs against v9, and leaving our setup on v8 for now?

@JoshuaKGoldberg JoshuaKGoldberg requested a review from bradzacher May 9, 2024 15:04
JoshuaKGoldberg
JoshuaKGoldberg commented May 9, 2024
View reviewed changes
yarn.lock
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran yarn dedupe to trim this file down a bit. Then I reverted the tmp upgrades as they cause a few odd CI failures. #8589

@charliepark charliepark mentioned this pull request May 9, 2024
Closed
@mishankov mishankov mentioned this pull request May 10, 2024
Closed
@heyqbnk heyqbnk mentioned this pull request May 11, 2024
Open
@RobinTail

This comment has been minimized.

Sign in to view
@JoshuaKGoldberg JoshuaKGoldberg merged commit b765f7b into typescript-eslint:v8 May 12, 2024
62 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the eslint-9 branch May 12, 2024 23:30
@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request May 12, 2024
Closed
@JoshuaKGoldberg
Copy link
Member Author

JoshuaKGoldberg commented May 13, 2024 •
edited
Loading

Now that this is merged, the v8 versions of typescript-eslint starting with v8.0.0-alpha.10 now support ESLint v9. Hooray! 🙌

If you still have problems with typescript-eslint and ESLint v9:

  1. Please make sure you're using typescript-eslint@8.0.0-alpha.10 or newer
  2. Go through our issue chooser to file a new issue reporting your problems
    • That issue template includes searching for existing issues matching your problem - please do not file duplicate issues

Note that we do not plan on backporting ESLint v9 support to v7 versions of typescript-eslint. There are a lot of breaking changes inherent to our ESLint v9 support.

If any enterprising individual wants to try onboarding us in typescript-eslint to ESLint v9, #9082 tracks that as a followup.

@auvred auvred mentioned this pull request May 13, 2024
Merged
26 tasks
@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request May 13, 2024
Open
7 tasks
@rubiesonthesky rubiesonthesky mentioned this pull request May 13, 2024
Merged
3 tasks
@patwork patwork mentioned this pull request May 18, 2024
Merged
@wakamsha wakamsha mentioned this pull request May 20, 2024
Closed
@JoCa96 JoCa96 mentioned this pull request May 22, 2024
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@karlhorky karlhorky karlhorky left review comments

@auvred auvred auvred approved these changes

@bradzacher bradzacher Awaiting requested review from bradzacher

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JoshuaKGoldberg @RobinTail @karlhorky @bradzacher @auvred