fix(typescript-estree): adds project service watch to add new files to project #9353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…typescript-eslint#8834) * feat(typescript-estree): remove slow deprecated and isolated programs * Update packages/typescript-estree/src/create-program/createProjectProgram.ts Co-authored-by: Brad Zacher <brad.zacher@gmail.com> --------- Co-authored-by: Brad Zacher <brad.zacher@gmail.com>
typescript-eslint#8920) * fix(typescript-estree): add TSEnumBody node for TSEnumDeclaration body * Fixed up tests and their snapshots * More about enums * Indent too * Update packages/ast-spec/src/special/TSEnumBody/spec.ts Co-authored-by: Brad Zacher <brad.zacher@gmail.com> * parent types touchups * Update packages/visitor-keys/src/visitor-keys.ts Co-authored-by: Brad Zacher <brad.zacher@gmail.com> --------- Co-authored-by: Brad Zacher <brad.zacher@gmail.com>
…aint and key (typescript-eslint#7065) * feat(typescript-estree): split TSMappedType typeParameter into constraint and key * Aha, refactor to deduplicate - and fix property references * Updated scope-manager snapshots * Fixed snapshots, though not the bug * Remove comment, oops * Switch TSMappedType type visiting to be more manual * Lint fixes * Update packages/scope-manager/src/referencer/TypeVisitor.ts Co-authored-by: Brad Zacher <brad.zacher@gmail.com> * Avoided node.parent as directed --------- Co-authored-by: Brad Zacher <brad.zacher@gmail.com>
…t#8833) * feat(eslint-plugin): remove formatting/layout rules * Remove "layout" * feat(typescript-estree): add defaultProject for project service (typescript-eslint#8815) * feat(typescript-estree): add defaultProject for project service * Thanks Jake, service.setCompilerOptionsForInferredProjects * Cleaned up a bit and added happy path testing * Update packages/typescript-estree/src/parser-options.ts Co-authored-by: Brad Zacher <brad.zacher@gmail.com> --------- Co-authored-by: Brad Zacher <brad.zacher@gmail.com> * feat(eslint-plugin): replace `no-new-symbol` with `no-new-native-nonconstructor` (typescript-eslint#8895) Co-authored-by: Brad Zacher <brad.zacher@gmail.com> * Add tombstones * 'deprecated' typo * Let's mention both issues * Fix unused variable issue --------- Co-authored-by: Brad Zacher <brad.zacher@gmail.com> Co-authored-by: Dave <reduckted@outlook.com>
…onalTests default to true (typescript-eslint#8872)
…ypescript-eslint#8832) * feat(eslint-plugin): deprecate no-loss-of-precision extension rule * baseRule.create, nice Kirk
* feat(typescript-estree): remove slow deprecated and isolated programs (typescript-eslint#8834) * feat(typescript-estree): remove slow deprecated and isolated programs * Update packages/typescript-estree/src/create-program/createProjectProgram.ts Co-authored-by: Brad Zacher <brad.zacher@gmail.com> --------- Co-authored-by: Brad Zacher <brad.zacher@gmail.com> * fix(typescript-estree): add TSEnumBody node for TSEnumDeclaration body (typescript-eslint#8920) * fix(typescript-estree): add TSEnumBody node for TSEnumDeclaration body * Fixed up tests and their snapshots * More about enums * Indent too * Update packages/ast-spec/src/special/TSEnumBody/spec.ts Co-authored-by: Brad Zacher <brad.zacher@gmail.com> * parent types touchups * Update packages/visitor-keys/src/visitor-keys.ts Co-authored-by: Brad Zacher <brad.zacher@gmail.com> --------- Co-authored-by: Brad Zacher <brad.zacher@gmail.com> * remove getTypeArguments * one lil ' --------- Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com> Co-authored-by: Brad Zacher <brad.zacher@gmail.com>
…t-eslint#8934) * feat(typescript-estree): remove slow deprecated and isolated programs (typescript-eslint#8834) * feat(typescript-estree): remove slow deprecated and isolated programs * Update packages/typescript-estree/src/create-program/createProjectProgram.ts Co-authored-by: Brad Zacher <brad.zacher@gmail.com> --------- Co-authored-by: Brad Zacher <brad.zacher@gmail.com> * fix(typescript-estree): add TSEnumBody node for TSEnumDeclaration body (typescript-eslint#8920) * fix(typescript-estree): add TSEnumBody node for TSEnumDeclaration body * Fixed up tests and their snapshots * More about enums * Indent too * Update packages/ast-spec/src/special/TSEnumBody/spec.ts Co-authored-by: Brad Zacher <brad.zacher@gmail.com> * parent types touchups * Update packages/visitor-keys/src/visitor-keys.ts Co-authored-by: Brad Zacher <brad.zacher@gmail.com> --------- Co-authored-by: Brad Zacher <brad.zacher@gmail.com> * chore(type-utils)!: remove IsNullableTypeOptions interface --------- Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com> Co-authored-by: Brad Zacher <brad.zacher@gmail.com>
…owAutomaticSingleRunInference (typescript-eslint#8922) * feat(typescript-estree): disallowAutomaticSingleRunInference, off (fast) by default * Unnecessary Infinity cache lifetime too * disallowAutomaticSingleRunInference in RuleTester * Add more explicit disallowAutomaticSingleRunInference: true,s * Fixed for parse.test.ts * Fixed persistentParse.test.ts and semanticInfo.test.ts * disallowAutomaticSingleRunInference in docs.test.ts * Reset plugin .shot files * Fix unit tests for Windows * lint
…slint#8617) * feat!(parser): always enable comment, loc, range, tokens * fix: tests * Smooth out the Object.assign * test: added some more for parser, why not
…ypescript-eslint#8972) * feat(utils): swap LegacyESLint out for FlatESLint as ESLint export * eslint@v10 comment
…owAutomaticSingleRunInference option (typescript-eslint#9013)
…nt#9029) * chore: fix v8 branch snapshots for flat-config-types * Check in the rest of them too
…ript-eslint#9006) docs: remove eslint v9 tracking issue from main readme
remove deprecated context helpers
typescript-eslint#9025) * feat(utils): [RuleCreator] require specifying additional rule meta.docs * test fix * Explicit start and end types * Fix lint failures * lil more linting
…d no-empty-interfaces (typescript-eslint#8977) * feat(eslint-plugin): split no-empty-object-type rule out from ban-types rule * Mention no-props * Update packages/eslint-plugin/docs/rules/no-empty-object-type.mdx Co-authored-by: Kirk Waiblinger <53019676+kirkwaiblinger@users.noreply.github.com> * Update packages/eslint-plugin/docs/rules/no-empty-object-type.mdx Co-authored-by: Kirk Waiblinger <53019676+kirkwaiblinger@users.noreply.github.com> * Allow in intersections, and touch up docs per suggestions * Update packages/eslint-plugin/docs/rules/no-empty-object-type.mdx Co-authored-by: Joshua Chen <sidachen2003@gmail.com> * Trimming * Update snapshots * Finish removing Record * Correct phrasing on Object * Merge with no-empty-interface * nit the tip * Explicit report message for interfaces * Add in-type-alias-with-name * Switched to more general allowWithName * snapshot -u * snapshot -u * Fixed up unit tests * Update packages/eslint-plugin/docs/rules/no-empty-object-type.mdx Co-authored-by: Kirk Waiblinger <kirk.waiblinger@gmail.com> * docs touchups from Kirk * replacedBy too --------- Co-authored-by: Kirk Waiblinger <53019676+kirkwaiblinger@users.noreply.github.com> Co-authored-by: Joshua Chen <sidachen2003@gmail.com> Co-authored-by: Kirk Waiblinger <kirk.waiblinger@gmail.com>
* feat: support ESLint 9 * Fix some eslint-plugin tests * Re-add v8 and remove unnecessary peerDependencies * Fix no-unused-vars test rule * Updated snapshots * put back tmp@0.2.1 * Fixed linting by disabling plugins temporarily * Update two more integration snapshots for no-unused-vars * Ugh, missing " * Remove legacy rule function form * Fix legacy-config test to actually use legacy config * Revert "Remove legacy rule function form" This reverts commit e053179. * Update ESLint 8/9 RuleCreateFunction comments * Start reverting the local dev changes * Some more reverts * oopsies comment level * yarn test -u the integration tests * regenerate yarn.lock * yarn dedupe, and undo some eslint.config changes * Remove extra node: * Finally revert nodeType changes * one more deprecation fix * Update eslint-plugin schemas snapshot * Annoying tmp version update * Add eslint_v9_tests * Fix yarn.lock
* fix(rule-tester): re-apply updates from main * Undo removals * Redo removals
…eslint#9207) * remove no-useless-template-literals rule * fix no-useless-template-literals docs * revert removal * keep as tombstone page * fix doc * fix docs test * fix doc
…ls' option (typescript-eslint#9234) * feat(eslint-plugin): [no-floating-promises] add 'allowForKnownSafePromiseReturns' option * test: always with the snapshots * fix unit test file relativity * Add .then test * Update option name: allowForKnownSafeCalls * Add .finally test
…ParserOptions (typescript-eslint#9287) * feat(typescript-estree): also remove projectService in withoutProjectParserOptions * ...I could have sworn I checked in this file too
…nsafe-function-type, no-wrapper-object-types (typescript-eslint#9102) * feat(eslint-plugin): add no-restricted-types, no-uppercase-alias-types rules * Fix lint issues * Apply suggestions from code review Co-authored-by: Kirk Waiblinger <kirk.waiblinger@gmail.com> * Kirk suggestions * yarn test -u * test: fix tests for useProgramFromProjectService * Rename to no-wrapper-object-types * excess myObject in docs * Fix rules/index.ts * Clarify ban-types deprecation message * Remove ban-types altogether * fix website build with permalink to ban-types * Update configs * Apply suggestions from code review Co-authored-by: Joshua Chen <sidachen2003@gmail.com> Co-authored-by: Brad Zacher <brad.zacher@gmail.com> * fix ban-types.md * Update packages/eslint-plugin/docs/rules/no-wrapper-object-types.mdx Co-authored-by: Joshua Chen <sidachen2003@gmail.com> * lil nit * remove callable type * Split out no-unsafe-function-type too * fix /blog link in ban-types.md * Mention args: never * Regenerate configs * lil phrasing nit * chore: fix snapshot * fix lint complaint * Address feedback * Apply suggestions from code review Co-authored-by: Kirk Waiblinger <kirk.waiblinger@gmail.com> * Mention concepts and equality * fix: scope analysis * ban-types.md rule mentions * fix no-restricted-types docs test * wrong list, kronk --------- Co-authored-by: Kirk Waiblinger <kirk.waiblinger@gmail.com> Co-authored-by: Joshua Chen <sidachen2003@gmail.com> Co-authored-by: Brad Zacher <brad.zacher@gmail.com>
|
Thanks for the PR, @higherorderfunctor! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit d3c3b25. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
This was referenced Jun 14, 2024
4 tasks
|
Closing this out to keep the PR queue small - thanks again for all your work on this! ❤️ If it ends up we do need to add watch logic to the project service, we can always re-open. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
tsconfig.jsonnot respected in new files when multiple tsconfigs include the same directory withprojectServiceenabled #8835Overview
Currently extracting MVP solution from combined solution for multiple issues.
Current implementation is really basic: index watch request and trigger most specific. Some things I need to dig into:
Would be nice to hook into tsserver lsp some how since its duplicating a lot of work.