Skip to content

[DO NOT LAND] Experiment with using pops in the current interpreter #7762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 39 commits into
base: main
Choose a base branch
from
Draft
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
weird
  • Loading branch information
kripken committed Jul 24, 2025
commit 1d2f536df68f415ecf9453b262af48636dc95615
7 changes: 4 additions & 3 deletions src/wasm-interpreter.h
Original file line number Diff line number Diff line change
Expand Up @@ -242,9 +242,10 @@ class ExpressionRunner : public OverriddenVisitor<SubType, Flow> {
protected:
RelaxedBehavior relaxedBehavior = RelaxedBehavior::NonConstant;

std::vector<Literals> valueStack;
// TODO: Literals here and not Flows
std::vector<Flow> valueStack;

Literals pop() {
Flow pop() {
assert(!valueStack.empty());
auto ret = valueStack.back();
valueStack.pop_back();
Expand Down Expand Up @@ -274,7 +275,7 @@ class ExpressionRunner : public OverriddenVisitor<SubType, Flow> {
if (flow.breaking()) {
return flow;
}
valueStack.push_back(flow.values);
valueStack.push_back(flow);
}
}
auto ret = OverriddenVisitor<SubType, Flow>::visit(curr);
Expand Down