Skip to content

[DO NOT LAND] Experiment with using pops in the current interpreter #7762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 39 commits into
base: main
Choose a base branch
from
Draft

[DO NOT LAND] Experiment with using pops in the current interpreter #7762

Changes from 1 commit
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
7984f03
yolo
kripken Jul 24, 2025
9685d6e
script
kripken Jul 24, 2025
93ea61c
script
kripken Jul 24, 2025
ba18f37
script
kripken Jul 24, 2025
7093708
work
kripken Jul 24, 2025
53c3657
work
kripken Jul 24, 2025
09fbf00
work
kripken Jul 24, 2025
8d8022a
work
kripken Jul 24, 2025
4db3030
work
kripken Jul 24, 2025
1d2f536
weird
kripken Jul 24, 2025
f81efad
TRY.maybe.revert
kripken Jul 24, 2025
1d6fc38
FIX
kripken Jul 24, 2025
0da3cfa
order.debug
kripken Jul 24, 2025
87b74e7
fix
kripken Jul 24, 2025
7c40729
nicer
kripken Jul 24, 2025
2b1af67
fix
kripken Jul 24, 2025
7409bca
revertfix
kripken Jul 24, 2025
d683b38
fix
kripken Jul 24, 2025
ca5d8cd
undo
kripken Jul 24, 2025
675a306
fixen
kripken Jul 24, 2025
483f5f9
fix
kripken Jul 24, 2025
2b8a16e
clean
kripken Jul 24, 2025
13c35fe
fix
kripken Jul 25, 2025
26d09a7
fix
kripken Jul 25, 2025
2b43ba8
simpl
kripken Jul 25, 2025
f660691
tryfix
kripken Jul 25, 2025
3d3bb69
chaks
kripken Jul 25, 2025
876d246
typo
kripken Jul 25, 2025
38f14db
simpl
kripken Jul 25, 2025
7b08621
fix
kripken Jul 25, 2025
e2740d4
fix
kripken Jul 25, 2025
be17df4
format
kripken Jul 25, 2025
e36ac68
clean
kripken Jul 25, 2025
a6884eb
faster
kripken Jul 25, 2025
e11e69c
faster
kripken Jul 25, 2025
317967d
faster
kripken Jul 25, 2025
a823f14
SIMPL?
kripken Jul 25, 2025
8e24404
simpler
kripken Jul 25, 2025
f26e8a7
common
kripken Jul 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
format
  • Loading branch information
@kripken
kripken committed Jul 25, 2025
commit be17df40b9527b4612876c38da88a9b40e5c18ef
18 changes: 11 additions & 7 deletions src/wasm-interpreter.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@
#include <variant>

#include "fp16.h"
#include "ir/iteration.h"
#include "ir/intrinsics.h"
#include "ir/iteration.h"
#include "ir/module-utils.h"
#include "ir/properties.h"
#include "support/bits.h"
Expand Down Expand Up @@ -3084,7 +3084,8 @@ class ModuleRunnerBase : public ExpressionRunner<SubType> {

Flow ret = callFunction(target, arguments);
#if WASM_INTERPRETER_DEBUG
std::cout << self()->indent() << "(returned to " << scope->function->name << ")\n";
std::cout << self()->indent() << "(returned to " << scope->function->name
<< ")\n";
#endif
return ret;
}
Expand Down Expand Up @@ -3114,7 +3115,8 @@ class ModuleRunnerBase : public ExpressionRunner<SubType> {
Flow ret = info.interface()->callTable(
info.name, index, curr->heapType, arguments, curr->type, *self());
#if WASM_INTERPRETER_DEBUG
std::cout << self()->indent() << "(returned to " << scope->function->name << ")\n";
std::cout << self()->indent() << "(returned to " << scope->function->name
<< ")\n";
#endif
return ret;
}
Expand All @@ -3140,7 +3142,8 @@ class ModuleRunnerBase : public ExpressionRunner<SubType> {

Flow ret = callFunction(targetRef.getFunc(), arguments);
#if WASM_INTERPRETER_DEBUG
std::cout << self()->indent() << "(returned to " << scope->function->name << ")\n";
std::cout << self()->indent() << "(returned to " << scope->function->name
<< ")\n";
#endif
return ret;
}
Expand Down Expand Up @@ -4065,7 +4068,8 @@ class ModuleRunnerBase : public ExpressionRunner<SubType> {
FunctionScope scope(function, arguments, *self());

#if WASM_INTERPRETER_DEBUG
std::cout << self()->indent() << "entering " << function->name << "\n with arguments:\n";
std::cout << self()->indent() << "entering " << function->name
<< "\n with arguments:\n";
for (unsigned i = 0; i < arguments.size(); ++i) {
std::cout << " $" << i << ": " << arguments[i] << '\n';
}
Expand All @@ -4074,8 +4078,8 @@ class ModuleRunnerBase : public ExpressionRunner<SubType> {
flow = self()->visit(function->body);

#if WASM_INTERPRETER_DEBUG
std::cout << self()->indent() << "exiting " << function->name << " with " << flow.values
<< '\n';
std::cout << self()->indent() << "exiting " << function->name << " with "
<< flow.values << '\n';
#endif

if (flow.breakTo != RETURN_CALL_FLOW) {
Expand Down