Skip to content

[DO NOT LAND] Experiment with using pops in the current interpreter #7762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 39 commits into
base: main
Choose a base branch
from
Draft
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
clean
  • Loading branch information
kripken committed Jul 24, 2025
commit 2b8a16e6a85893835bed23834855b26254be9e87
4 changes: 0 additions & 4 deletions src/wasm-interpreter.h
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,6 @@ class ExpressionRunner : public OverriddenVisitor<SubType, Flow> {

Flow visitBlock(Block* curr) {
NOTE_ENTER("Block");
std::cout << indent() << "BLOCK name " << curr->name << '\n';
// special-case Block, because Block nesting (in their first element) can be
// incredibly deep
std::vector<Block*> stack;
Expand All @@ -324,7 +323,6 @@ std::cout << indent() << "BLOCK name " << curr->name << '\n';
stack.pop_back();
if (flow.breaking()) {
flow.clearIf(curr->name);
std::cout << indent() << " breaking, me" << curr->name << " leaving " << flow << '\n';
continue;
}
auto& list = curr->list;
Expand All @@ -336,12 +334,10 @@ std::cout << indent() << " breaking, me" << curr->name << " leaving " << flow <<
flow = visit(list[i]);
if (flow.breaking()) {
flow.clearIf(curr->name);
std::cout << indent() << "inner breaking, me" << curr->name << " leaving " << flow << '\n';
break;
}
}
}
std::cout << indent() << "BLOCK final flow, me" << curr->name << " leaving " << flow << '\n';
return flow;
}
Flow visitIf(If* curr) {
Expand Down