Skip to content

[DO NOT LAND] Experiment with using pops in the current interpreter #7762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 39 commits into
base: main
Choose a base branch
from
Draft
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
common
  • Loading branch information
kripken committed Jul 25, 2025
commit f26e8a7c3f97dc2ae381ca33d0135ada3931eb8c
9 changes: 3 additions & 6 deletions src/wasm-interpreter.h
Original file line number Diff line number Diff line change
Expand Up @@ -417,8 +417,7 @@ class ExpressionRunner : public OverriddenVisitor<SubType, Flow> {
// delegate to the Literal::* methods, except we handle traps here.

Flow visitUnary(Unary* curr) {
Flow flow = getChild();
Literal value = flow.getSingleValue();
auto value = getSingleChild();
switch (curr->op) {
case ClzInt32:
case ClzInt64:
Expand Down Expand Up @@ -695,10 +694,8 @@ class ExpressionRunner : public OverriddenVisitor<SubType, Flow> {
WASM_UNREACHABLE("invalid op");
}
Flow visitBinary(Binary* curr) {
Flow flow = getChild();
Literal left = flow.getSingleValue();
flow = getChild();
Literal right = flow.getSingleValue();
auto left = getSingleChild();
auto right = getSingleChild();
assert(curr->left->type.isConcrete() ? left.type == curr->left->type
: true);
assert(curr->right->type.isConcrete() ? right.type == curr->right->type
Expand Down
Loading