Skip to content

WIP: :add bytes __add__, __contain__, __getitem__ #738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 70 commits into from
Closed

WIP: :add bytes __add__, __contain__, __getitem__ #738

wants to merge 70 commits into from

Conversation

jgirardet
Copy link
Contributor

TODO at #736

OddCoincidence
OddCoincidence reviewed Mar 23, 2019
View reviewed changes
@codecov-io
Copy link

codecov-io commented Mar 23, 2019 •
edited
Loading

Codecov Report

Merging #738 into master will increase coverage by 15.73%.
The diff coverage is 57.68%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #738       +/-   ##
===========================================
+ Coverage    45.9%   61.64%   +15.73%     
===========================================
  Files          81       80        -1     
  Lines       16164    12790     -3374     
  Branches     3966     2663     -1303     
===========================================
+ Hits         7420     7884      +464     
+ Misses       6945     3175     -3770     
+ Partials     1799     1731       -68
Impacted Files Coverage Δ
vm/src/obj/objiter.rs 70% <ø> (+29.72%) ⬆️
vm/src/obj/objtuple.rs 56.64% <ø> (+14.94%) ⬆️
vm/src/obj/objmemory.rs 35.71% <0%> (+17.19%) ⬆️
wasm/lib/src/browser_module.rs 0% <0%> (ø) ⬆️
vm/src/exceptions.rs 46.92% <0%> (+9.18%) ⬆️
vm/src/stdlib/types.rs 0% <0%> (ø) ⬆️
src/main.rs 20% <0%> (+6.66%) ⬆️
wasm/lib/src/wasm_builtins.rs 0% <0%> (ø) ⬆️
wasm/lib/src/vm_class.rs 0% <0%> (ø) ⬆️
vm/src/obj/objenumerate.rs 71.05% <0%> (+27.5%) ⬆️
... and 97 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4666a09...90fc86b. Read the comment docs.

jgirardet
jgirardet commented Mar 24, 2019
View reviewed changes
@jgirardet jgirardet changed the title WIP: :add missing bytes method WIP: :add bytes __add__, __contain__, __getitem__ Mar 25, 2019
cthulahoops and others added 26 commits March 25, 2019 16:34
@cthulahoops
builtin_locals can just return a reference to the locals dict.
17c3f9f
@adrian17
Update grcov
602f2a8
@cthulahoops
Various dictionary changes.
bbb7162 
* vm.ctx.new_dict returns a PyDictRef
* Special case for module goes away.
* Instances get a real dictionary.
@cthulahoops
AST class for nodes instead of just using object everywhere.
55e0fb1
@adrian17
Avoid trace log in tests
e44b02b
@adrian17
Do not run benchmarks in the main test suite
4ab59a8
@adrian17
Run rustpython tests without cargo middleman
16e04cf
@adrian17
Clean up some tests
2131a81
@windelbouwman
Merge pull request #749 from adrian17/tests-cleanup
e47032f 
Tests cleanups
@windelbouwman
Merge pull request #725 from palaviv/frozen-set-2
983be0f 
frozenset
@windelbouwman
Fix build and add extend_class macro usage for set and frozenset
6ae10ed
@windelbouwman
Merge pull request #747 from adrian17/master
20c09f0 
Update grcov
@cthulahoops
Merge pull request #748 from RustPython/attributes_and_dictionaries
cac9da4 
Attributes and dictionaries
@cthulahoops
Fix objset compilation error caused by merge race.
17b816f
@OddCoincidence
Clean up TypeProtocol
cc4f3fd
@OddCoincidence
Remove objtype::get_type_name()
6474a4a
@OddCoincidence
Use name field directly
8bdc766
@OddCoincidence
Fix wasm
625d235
@cthulahoops
Merge pull request #750 from RustPython/joey/cleanup-type-protocol
e68eb9c 
Clean up type protocol
@cthulahoops
Change types inside Scope to PyDictRef.
4a5592d
@OddCoincidence
Merge pull request #751 from RustPython/scope_holds_dictionaries
5ef8220 
Change types inside Scope to PyDictRef.
@jgirardet
fix bytes.__repr__ according to pyton formating
4bee9d9
@adrian17
Remove .gcno files before a coverage run
c5203a4
@windelbouwman
Merge pull request #753 from adrian17/master
14d3aab 
Remove .gcno files before a coverage run
@jgirardet
fix class()
7044df8
@jgirardet
Merge branch 'bytes' into essai_merge
90fc86b
@jgirardet
Copy link
Contributor Author

ARgh I broke everything with git in the rebase/merge...
I'm gonna start a new clean PR to clean things

@jgirardet jgirardet closed this Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coolreader18 coolreader18 coolreader18 left review comments

@OddCoincidence OddCoincidence OddCoincidence left review comments

@windelbouwman windelbouwman windelbouwman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@jgirardet @codecov-io @windelbouwman @coolreader18 @OddCoincidence @palaviv @skinnyBat @adrian17 @cthulahoops