-
Notifications
You must be signed in to change notification settings - Fork 877
DAU graph misleads admins on license utilization #15297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Instead of calling it licensed utilization chart, I suggest we call registered users count graph. It's helpful to know how the total registered users go over time on both OSS and licensed deployments. We can put a horizontal line to indicate the limit for licensed deployments. |
I just added these to this issue as should have and nice to have. We want to remove the confusion quickly, but if the should haves are relatively easy we get to do that now too. If it is more difficult, we can extract to a separate issue. I totally agree that with just the should have, many users may still confuse that chart as utilization and registered users would be a very useful chart. |
@BrunoQuaresma do you think it is possible to do the "must have" part at least before the release? The "should have" can follow after the release as subsequent PRs? |
@bpmct sure thing. I just would need the copy for the "Explain in the tooltip that this is for measuring user activity and has no connection to license consumption". |
Since we are touching on this part of the UI, I think would be nice to have some thoughts from @chrifro on how to better display this data to the user. |
This should be on |
I don't think we need much redesign, we can use the existing graph component for "registered users" IMO. |
We said the same about the forgot password 😆 I would like to have @chrifro decide. |
👋 I'd suggest that we add a design polish as a "nice to have". It shouldn't block the content changes that are requested by the customer and are more time-sensitive. At the same time, we can definitely make the graph visually more appealing and help to grasp the information quickly. Some ideas:
I could create the design early next week. Let me know if I should focus on that. Btw, thanks for the the great issue description @stirby, makes it easy to dive into this 🙏 |
FYI not a "must-do" anymore |
@chrifro from the shadcn example charts, do you have a type preference? I think for this case, a stacked area chart could work very well. What do you think? |
That's exactly the one I had in mind as well 👌 |
Maybe something likeThis is AI generated at https://v0.dev |
Here’s the current situation: we have not implemented a redesign for the charts or this page, so I'm focusing on making only the necessary changes. @chrifro, please let me know if you would like to redesign the component now or if you prefer to do it later. EDITED: I just realized that we need the total number of registered users, not just the new users. Making the correction now... |
We can stick to your version for now. It's a great improvement ✨ For the colors, are you using existing colors? If not, could you use the blue and green that are defined in the new design system? Related issue #14780 |
Yep, we need a chart that shows the total users against the seat count. We do not have to put everything in the same chart, however. |
Potential partial blocker that I need input on. In short, I need to propose that we opt for a point in time gauge instead of a graph over time for total users against seat count. At least for this release. This is because: We don't track history for when users change status. We can't accurately display historical license count, because we only know whether a user is dormant or active today. We don't know when that changed. The same goes for when users where deleted. We know whether or not they were deleted. We don't know when they were deleted. I can get a gauge done by release. The changes that need to be made to the db schema to support historical stats for dormancy and deletion require more consideration. |
We already have a point-in-time value for registered users on the
What we need new is as @bpmct said a new chart to show the growth of registered users. Can you paste a mockup of what is your proposal for what to put in this release? |
What you've pasted there is what I had in mind. I'm glad we already have it. Do we care about registered users or about license utilization? The original problem statement above is this:
If we just want registered users over time regardless of whether or not they are consuming a license, then I can go ahead and fulfil the requirement. If we care about license utilisation, then I need to make larger changes to the DB schema that will take time. |
This PR is the first iteration towards #15297 We cannot yet show license utilization over time, so we show current license utilization. This is because we don't track user states over time. We only track the current user state. A graph over time filtering by active users would therefore not account for day to day changes in user state and be inaccurate. DB schema migrations and related updates will follow that allow us to show license utilization over time.  --------- Co-authored-by: ケイラ <mckayla@hey.com>
This PR is the first iteration towards #15297 We cannot yet show license utilization over time, so we show current license utilization. This is because we don't track user states over time. We only track the current user state. A graph over time filtering by active users would therefore not account for day to day changes in user state and be inaccurate. DB schema migrations and related updates will follow that allow us to show license utilization over time.  --------- Co-authored-by: ケイラ <mckayla@hey.com> (cherry picked from commit 7e1ac2e)
Based on the conversations above, I've created this issue: I created a new one because I would like to clarify priority for the remaining graph. It would be easier to track in isolation. It specifically captures the outstanding feature and documents how to achieve it. Everything else in this current issue has been accomplished. I propose we close this issue and shift it's focus to the new one. Objections? |
I am ok with closing this. But we can keep it open to track the nice to haves. |
Keeping open until we have a new time series graph for license utilization. |
Status update: |
RE: #15740, #15297 In order to add a graph to the coder frontend to show user status over time as an indicator of license usage, this PR adds the following: * a new `api.insightsUserStatusCountsOverTime` endpoint to the API * which calls a new `GetUserStatusCountsOverTime` query from postgres * which relies on two new tables `user_status_changes` and `user_deleted` * which are populated by a new trigger and function that tracks updates to the users table The chart itself will be added in a subsequent PR --------- Co-authored-by: Mathias Fredriksson <mafredri@gmail.com>
Status update. Changes have been merged that allow the database and backend to support this feature. A frontend PR is ready, but designs have since shifted and some more work on the frontend is required. To my knowledge, @BrunoQuaresma has agreed to support here. I've co-assigned him to the issue. |
@SasSwart @BrunoQuaresma Can you describe the scope of remaining changes for transparency purposes? Unless they are documented somewhere else. |
The design has been updated and should now follow the design outlined here. |
Related to #15297 and based on [this design](https://www.figma.com/design/gtVchocIWPGYjzaHD2OIY7/Setting-page?node-id=16-1848&m=dev).
Related to #15297 and based on [this design](https://www.figma.com/design/gtVchocIWPGYjzaHD2OIY7/Setting-page?node-id=16-1848&m=dev).
The General page is going to use the old API, but we rename the series on the UI to unconfuse the users. We also add additional explanation box. The new API that Sas created is for the License page. In scope of the discussion we decided to use only the "Active Users" series from the API, so the "dormant" and "suspended" users will not be displayed. But the active users there are in fact the "users consuming the license seats" which is different from the "General page", where we show the daily user engagement. To sum up:
|
Credit to @coadler for distilling this issue from customer feedback.
Problem statement
The General deployment settings page (dev link) contains a graph of daily active users across the deployment. This graph is purely intended to measure the adoption of the product within an organization and summarize user activity. Here's what this graph looks like in our dogfood deployment:
However, for enterprise deployments with a license cap, a "user limit" bar appears at the top. This misleads admins into thinking this is a way to gauge license usage over time and judge whether expansion/contraction is necessary:
The (?) tooltip doesn't clarify the purpose of this graph to admins either, simply explaining how activity is calculated:
This ambiguity is a problem for administrators. To summarize
Proposal
We should clarify that this graph is purely to measure concurrent user activity.
Requirements:
Must have:
Should have:
Nice to have:
The text was updated successfully, but these errors were encountered: