Skip to content

feat: enable oauth2 token exchange #12127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

feat: enable oauth2 token exchange #12127

wants to merge 1 commit into from

Conversation

code-asher
Copy link
Member

@code-asher code-asher commented Feb 13, 2024 •
edited
Loading

Stale bot closed the other and will not let me reopen after I force pushed, so here is a new one.

Closes #11084

Stacked manually so I can compare the experience to Graphite. Depends on:

TODO

  • /authorize static page
  • /authorize redirect
  • /tokens GET
  • /tokens DELETE (revoke)
  • Add endpoints for discoverability
  • Refresh auth grant flow
    • Disable auto-refresh on oauth-generated API keys
  • Hash secrets
  • Handle other auth styles
  • Handle no user agent for /authorize. Return text payload with href??
  • Audit logs
    • Create app
    • Delete app
    • Edit app
    • Create secret
    • Delete secret
    • Revoke app?
    • Authorize app?
    • Token exchange?
  • Allow admin to revoke an app for a user
  • Documentation
  • Could use an upsert for replacing the code
  • Does not seem to be redirecting to login

@code-asher code-asher changed the base branch from main to asher/oauth2-exchange-fe February 13, 2024 19:33
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 13, 2024 •
edited
Loading

✔️ PR 12127 Updated successfully.
🚀 Access the credentials here.

cc: @code-asher

@code-asher code-asher mentioned this pull request Feb 13, 2024
Merged
@code-asher code-asher force-pushed the asher/oauth2-exchange-fe branch from ca0bd42 to 1bb60b7 Compare February 13, 2024 22:23
@code-asher code-asher force-pushed the asher/oauth2-exchange branch from 600deb6 to 9165803 Compare February 13, 2024 22:23
@code-asher code-asher force-pushed the asher/oauth2-exchange-fe branch from 1bb60b7 to 678f900 Compare February 21, 2024 00:00
@code-asher code-asher force-pushed the asher/oauth2-exchange branch from 9165803 to 48d89ad Compare February 21, 2024 00:04
Base automatically changed from asher/oauth2-exchange-fe to main February 21, 2024 23:16
@code-asher code-asher force-pushed the asher/oauth2-exchange branch from 48d89ad to 7cc6d6f Compare February 22, 2024 21:34
@github-actions github-actions bot added the stale This issue is like stale bread. label Mar 2, 2024
@github-actions github-actions bot closed this Mar 5, 2024
@github-actions github-actions bot deleted the asher/oauth2-exchange branch August 23, 2024 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@code-asher code-asher

Labels
stale This issue is like stale bread.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow Coder to be an OAuth provider
1 participant
@code-asher