fix(ci): fix winget installer workflow #5569
Merged
+16
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```yaml
env:
GH_TOKEN: ${{ github.token }}
```
Needed for gh cli to work inside github actions
We do not need that last 0 to match the version with other platforms
wingetcreate specifically checks for https://github.com/microsoft/winget-create/blob/7c61f3e877f95f6c8ab60ed4e3a34d9449d7e774/src/WingetCreateCore/Common/PackageParser.cs#L466 to decide on application architecture.
deansheather
approved these changes
Jan 5, 2023
|
I reverted the filename back as we can force wingetcreate to accept our filename by adding |
|
I also submitted a new version manually as the architecture was incorrect on winget-pkgs which would cause any unattended updates to fail. From now on it should work hopefully 🤞 |
|
Seems like it's still not working :( https://github.com/coder/coder/actions/runs/3875913715/jobs/6609100482 |
|
The |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: winget automatic release
amd64withwin64wingetcreatespecifically checks for"x64,win64or_64strings in the installer URL to decide on application architecture.Source: (got the idea from here microsoft/winget-create#198)
https://github.com/microsoft/winget-create/blob/7c61f3e877f95f6c8ab60ed4e3a34d9449d7e774/src/WingetCreateCore/Common/PackageParser.cs#L466
other wise we get this error,
This PR closes #5266 and #5137