Skip to content

fix(site): use WebGL renderer for terminal #9320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 25, 2023
Merged

fix(site): use WebGL renderer for terminal #9320

merged 2 commits into from
Aug 25, 2023

Conversation

ammario
Copy link
Member

@ammario ammario commented Aug 24, 2023 •
edited
Loading

fix(site): use WebGL renderer for terminal

It's faster than Canvas.

Stack created with Sapling. Best reviewed with ReviewStack.

@ammario
fix(site): render variable width unicode characters in terminal
8121e4f 
Previously, characters such as 🟢 were given insufficient space, leading
to mangled output.
@ammario ammario mentioned this pull request Aug 24, 2023
Merged
@ammario ammario requested a review from code-asher August 24, 2023 22:46
@ammario ammario mentioned this pull request Aug 24, 2023
Closed
matifali
matifali reviewed Aug 25, 2023
View reviewed changes
site/package.json
@@ -103,7 +103,9 @@
"xterm": "5.2.1",
"xterm-addon-canvas": "0.4.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should canvas addon be removed or is it still being used somewhere?

@github-actions
Copy link

github-actions bot commented Aug 25, 2023 •
edited
Loading

✔️ PR 9320 Created successfully.
🚀 Access the credentials here.

cc: @matifali

@matifali matifali mentioned this pull request Aug 25, 2023
Closed
@mafredri
Copy link
Member

We should confirm that we don't re-introduce a regression with this change (c.f. #7953, #8138).

That was DOM vs canvas, though. So probably not applicable here. But better safe than sorry.

@matifali
Copy link
Member

matifali commented Aug 25, 2023 •
edited
Loading

@mafredri I tested htop and it was working fine no overlapping or anything, even with resizing. Do you suggest any further tests. we can test in our PR deployment.

@mafredri
Copy link
Member

@matifali nice! There's a lot we could test but I think htop is a good benchmark unless we know other potentially problematic software. A few others that come to mind: vim, emacs.

@ammario ammario added the hotfix PRs only. Harmless small change. Only humans may set this. label Aug 25, 2023
cdr-bot[bot]
cdr-bot bot approved these changes Aug 25, 2023
View reviewed changes
Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@ammario ammario merged commit 14f769d into main Aug 25, 2023
@ammario ammario deleted the pr9320 branch August 25, 2023 17:46
@github-actions github-actions bot locked and limited conversation to collaborators Aug 25, 2023
@matifali
Copy link
Member

cc: @BrunoQuaresma

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@matifali matifali matifali left review comments

@cdr-bot cdr-bot[bot] cdr-bot[bot] approved these changes

@code-asher code-asher Awaiting requested review from code-asher

Assignees

@ammario ammario

Labels
hotfix PRs only. Harmless small change. Only humans may set this.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ammario @mafredri @matifali