-
Notifications
You must be signed in to change notification settings - Fork 396
Traducción library/atexit #2708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perdón por la tardía revisión, tenía algunos comentarios ya en el tintero y ahora por fin pude terminarlos
Saludos, he realizado cambios en base a las correcciones presentadas |
@Sublian Si te fijas los tests están fallando aún. Dales una mirada y ve que hace falta arreglar. Cuando estén pasando de nuevo podemos proseguir |
@rtobar listo he revisado y corregido en base a los datos del test. Creo que falta menos |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gracias @Sublian, quedaron un par de cosas en el tintero
Lista la siguiente correción @rtobar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Closes #2625