Skip to content

Traducido library/wave #954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Oct 6, 2020
Merged

Traducido library/wave #954

merged 14 commits into from
Oct 6, 2020

Conversation

eflipe
Copy link
Contributor

@eflipe eflipe commented Oct 5, 2020

Closes #818

@eflipe
Copy link
Contributor Author

eflipe commented Oct 5, 2020

Ahora sí, gracias gente :)

@raulcd raulcd self-requested a review October 5, 2020 17:33
raulcd
raulcd reviewed Oct 5, 2020
View reviewed changes
Copy link
Collaborator

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hola!! Gracias por la traducción. El build está fallando por unos pequeños detalles en las referencias. Los nombres de métodos y referencias deben ser exactamente iguales que en el original:
Ejemplo:

:mod:`wave`

si en la traducción pones lo siguiente fallará ya que en vez del símbolo ` usas ':

:mod:'wave'

Sí lo dejas como el original funcionará.
Hay varias en el fichero, he puesto referencia a algunas.

library/wave.po Outdated
"realmente escritos. Para secuencias que no se pueden buscar, el valor "
"*nframes* debe ser preciso cuando se escriben los datos del primer cuadro. "
"Se puede lograr un valor *nframes* preciso llamando a: meth: `~ Wave_write."
"setnframes` o: meth:` ~ Wave_write.setparams` con el número de cuadros que "
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aquí hay varios más

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hola! gracias por las correcciones. ¿Cómo puedo hacer para realizar las correcciones desde github? O tengo que hacer un pull de todo?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cuando no son sugerencias de edición directas, tienes que hacerlo localmente, actualizar la rama (pues ya has aceptado cosas acá) y luego modificar y hacer otro commit en tu rama, y volver a hacer push, eso agregará otro commit acá y los cambios se iran acumulando

library/wave.po Outdated

#: ../Doc/library/wave.rst:135
msgid "Raise an error."
msgstr ""
msgstr "Levanta un error."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Raise se encuentra en la memoria de traducción como Lanza un error

eflipe and others added 8 commits October 5, 2020 15:09
@eflipe @raulcd
Update library/wave.po
ef852e0 
Co-authored-by: Raúl Cumplido <raulcumplido@gmail.com>
@eflipe @raulcd
Update library/wave.po
2790da1 
Co-authored-by: Raúl Cumplido <raulcumplido@gmail.com>
@eflipe @raulcd
Update library/wave.po
e50604e 
Co-authored-by: Raúl Cumplido <raulcumplido@gmail.com>
@eflipe @raulcd
Update library/wave.po
4f9d1e0 
Co-authored-by: Raúl Cumplido <raulcumplido@gmail.com>
@eflipe @raulcd
Update library/wave.po
a21dbea 
Co-authored-by: Raúl Cumplido <raulcumplido@gmail.com>
@eflipe @raulcd
Update library/wave.po
5c377ff 
Co-authored-by: Raúl Cumplido <raulcumplido@gmail.com>
@eflipe @raulcd
Update library/wave.po
a811f0b 
Co-authored-by: Raúl Cumplido <raulcumplido@gmail.com>
@eflipe @raulcd
Update library/wave.po
3fa3e52 
Co-authored-by: Raúl Cumplido <raulcumplido@gmail.com>
@cmaureir
Copy link
Collaborator

cmaureir commented Oct 5, 2020

Travis nos dice que le falta powrap, si tienes problemas avisame y lo paso yo ;)

@eflipe
Copy link
Contributor Author

eflipe commented Oct 5, 2020

Travis nos dice que le falta powrap, si tienes problemas avisame y lo paso yo ;)

Ahi lo mandé con powrap y todo. A ver que dice el amigo travis :P

@cmaureir
Copy link
Collaborator

cmaureir commented Oct 5, 2020

Los errores que hay ahora es que hay warnings respecto a los 'sphinx roles' (eso que ponen :algo:otra cosa) por lo general pasan por espacios que faltan al terminar un role:

cpython/Doc/library/wave.rst:14: WARNING: inconsistent term references in translated message. original: [':mod:`wave`'], translated: []
cpython/Doc/library/wave.rst:117: WARNING: inconsistent term references in translated message. original: [':class:`bytes`'], translated: []
cpython/Doc/library/wave.rst:156: WARNING: inconsistent term references in translated message. original: [':meth:`~Wave_write.setnframes`', ':meth:`~Wave_write.setparams`', ':meth:`~Wave_write.close`', ':meth:`~Wave_write.writeframesraw`', ':meth:`~Wave_write.writeframes`', ':meth:`~Wave_write.writeframes`'], translated: [':meth:`~ Wave_write.setparams`', ':meth:`~ Wave_write.writeframes`']
cpython/Doc/library/wave.rst:168: WARNING: inconsistent term references in translated message. original: [':func:`.open`'], translated: []
cpython/Doc/library/wave.rst:176: WARNING: inconsistent term references in translated message. original: [':mod:`wave`'], translated: []
cpython/Doc/library/wave.rst:216: WARNING: inconsistent term references in translated message. original: [':meth:`set\\*`'], translated: []
cpython/Doc/library/wave.rst:223: WARNING: inconsistent term references in translated message. original: [':meth:`Wave_read.tell`', ':meth:`Wave_read.setpos`'], translated: []
cpython/Doc/library/wave.rst:231: WARNING: inconsistent term references in translated message. original: [':term:`bytes-like object`'], translated: []
cpython/Doc/library/wave.rst:242: WARNING: inconsistent term references in translated message. original: [':term:`bytes-like object`'], translated: []

cmaureir
cmaureir reviewed Oct 5, 2020
View reviewed changes
@cmaureir
Copy link
Collaborator

cmaureir commented Oct 5, 2020

Te dejé uno de los errores señalados, busca los otros por lo que dice el log que pegué y si necesitas ayuda con alguno, nos dices.

eflipe and others added 3 commits October 5, 2020 18:36
@eflipe @cmaureir
Update library/wave.po
16c09dd 
Co-authored-by: Cristián Maureira-Fredes <cmaureir@users.noreply.github.com>
@eflipe
traducción library/wave
fe3a0c5
@eflipe
traducción library/wave
e47ea27
cmaureir
cmaureir requested changes Oct 6, 2020
View reviewed changes
@eflipe @cmaureir
Update library/wave.po
36a1e4b 
Co-authored-by: Cristián Maureira-Fredes <cmaureir@users.noreply.github.com>
cmaureir
cmaureir approved these changes Oct 6, 2020
View reviewed changes
Copy link
Collaborator

@cmaureir cmaureir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Genial! lo has conseguido :)

@cmaureir cmaureir merged commit 9b4831e into python:3.8 Oct 6, 2020
@cmaureir
Copy link
Collaborator

cmaureir commented Oct 6, 2020

🎉 🎉 @eflipe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulcd raulcd raulcd left review comments

@cmaureir cmaureir cmaureir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Translate 'library/wave.po'
3 participants
@eflipe @cmaureir @raulcd