Skip to content

v20 #2591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 69 commits into from
Closed

v20 #2591

wants to merge 69 commits into from

Conversation

Bibo-Joshi
Copy link
Member

@Bibo-Joshi Bibo-Joshi commented Jul 14, 2021 •
edited
Loading

We can use this PR to gather notes for the future transition guide - similarly to #1982

docs are rendered at https://python-telegram-bot.readthedocs.io/en/v14/

updates to the wiki are gathered at the v14 branch of https://github.com/python-telegram-bot/python-telegram-bot.wiki.git - it's not visible in the wiki, but you can clone and edit it locally.

TODO:

  • Add wiki page on warnings and logging
  • Add wiki page on new builder pattern
  • Try to figure out the issue with passports and data.copy() in TGObject._parse_data()
  • Change https://git.io/JtcyU to the code above in the issue body as html comment
  • To add in transition guide: Adaption of pickled data to v14
  • Release notes for a (beta) version could ask users to test their proxy configs with the new version, since we will only be able to test that manually.

Before merging:

@Bibo-Joshi Bibo-Joshi added this to the v14 milestone Jul 14, 2021
github-actions[bot]
github-actions bot reviewed Aug 13, 2021
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there. Relax, I am just a little warning for the maintainers to release directly after merging your PR, otherwise we have broken examples and people might get confused :)

github-actions[bot]
github-actions bot reviewed Aug 19, 2021
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Looks like you edited the (dev) requirements or the pre-commit hooks. I'm just a friendly reminder to keep the pre-commit hook versions in sync with the dev requirements and the additional dependencies for the hooks in sync with the requirements :)

github-actions[bot]
github-actions bot reviewed Aug 22, 2021
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Looks like you edited README.rst or README_RAW.rst. I'm just a friendly reminder to apply relevant changes to both of those files :)

@Bibo-Joshi Bibo-Joshi force-pushed the v14 branch 2 times, most recently from 930a615 to 12fe042 Compare September 9, 2021 05:52
@Bibo-Joshi Bibo-Joshi mentioned this pull request Sep 30, 2021
Closed
@harshil21 harshil21 added 🛠 breaking change type: breaking enhancement labels Oct 15, 2021
@Bibo-Joshi Bibo-Joshi force-pushed the v14 branch 3 times, most recently from 5c26c91 to 74c4270 Compare December 13, 2021 18:14
@Poolitzer Poolitzer force-pushed the v14 branch 2 times, most recently from 74c4270 to 65f3599 Compare December 18, 2021 09:52
Bibo-Joshi and others added 6 commits February 4, 2022 21:26
@Bibo-Joshi
Temporarily enable tests for the v14 branch
7b53d0f
@harshil21 @Bibo-Joshi
Move and Rename TelegramDecryptionError to telegram.error.PassportDec…
e8d7ba2 
…ryptionError (#2621)
@Poolitzer @Bibo-Joshi
Add Code Comment Guidelines to Contribution Guide (#2612)
daefa09 
Co-authored-by: Bibo-Joshi <22366557+Bibo-Joshi@users.noreply.github.com>
@revolter @Bibo-Joshi
Improve Type Hinting for CallbackContext (#2587)
f92eba3 
Co-authored-by: Hinrich Mahler <22366557+Bibo-Joshi@users.noreply.github.com>
@Poolitzer @Bibo-Joshi
Add Custom pytest Marker to Ease Development (#2628)
49b4658 
Co-authored-by: Bibo-Joshi <22366557+Bibo-Joshi@users.noreply.github.com>
@starry-shivam @Bibo-Joshi
Make BasePersistence Methods Abstract (#2624)
0527a4d 
Signed-off-by: starry69 <starry369126@outlook.com>
Co-authored-by: Hinrich Mahler <22366557+Bibo-Joshi@users.noreply.github.com>
harshil21 and others added 7 commits February 4, 2022 22:21
@harshil21 @Bibo-Joshi
Improve Code Quality & Test Suite (#2843)
09ada88
@harshil21 @Bibo-Joshi
Fix failing animation tests (#2865)
96395e6
@harshil21 @Bibo-Joshi
Add Method drop_chat/user_data to Dispatcher and Persistence (#2852)
5060a05
@harshil21 @Bibo-Joshi
Remove telegram.ReplyMarkup (#2870)
a8004c7
@DonalDuck004 @Bibo-Joshi @harshil21
Add Dispatcher.migrate_chat_data (#2848)
ba5f559 
Co-authored-by: Bibo-Joshi <22366557+Bibo-Joshi@users.noreply.github.com>
Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>
@murugu-21 @harshil21 @Bibo-Joshi
Replace git.io Links (#2872)
af1f0ea 
Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>
Co-authored-by: Bibo-Joshi <22366557+Bibo-Joshi@users.noreply.github.com>
@harshil21 @Bibo-Joshi
Return Plain Dicts from BasePersistence.get_*_data (#2873)
d8e3fb4
Bibo-Joshi and others added 5 commits February 9, 2022 17:30
@Bibo-Joshi @harshil21
Documentation Improvements (#2856, #2798, #2854, #2841)
dea487b 
Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>
@harshil21
Persistence of Bots: Refactor Automatic Replacement and Integration…
d117d21 
… with `TelegramObject` (#2893)
@Bibo-Joshi @tsnoam
@harshil21 @Poolitzer
Switch to asyncio (#2731)
ad5a1fb 
Co-authored-by: tsnoam <tsnoam@gmail.com>
Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>
Co-authored-by: Poolitzer <25934244+Poolitzer@users.noreply.github.com>
@harshil21 @Bibo-Joshi
Expand and Adjust filters.{Document, Sticker} (#2922)
4de11cd 
Co-authored-by: Hinrich Mahler <22366557+Bibo-Joshi@users.noreply.github.com>
@Bibo-Joshi
Add Python 3.10 to Test Suite (#2968)
ef8232d
@harshil21 harshil21 changed the title v14 v20 Apr 26, 2022
@Bibo-Joshi Bibo-Joshi mentioned this pull request May 5, 2022
Merged
@Bibo-Joshi Bibo-Joshi closed this May 6, 2022
@Bibo-Joshi Bibo-Joshi deleted the v14 branch May 6, 2022 17:47
@github-actions github-actions bot locked and limited conversation to collaborators May 13, 2022
@Bibo-Joshi Bibo-Joshi added 🔌 enhancement pr description: enhancement and removed enhancement labels Nov 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
🛠 breaking change type: breaking 🔌 enhancement pr description: enhancement
Projects
None yet
Milestone
v20.0a0
Development

Successfully merging this pull request may close these issues.