Skip to content

[BE] fix typo in torch/distributed/tensor/: childs -> children #156609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 23 commits into from
Closed

[BE] fix typo in torch/distributed/tensor/: childs -> children #156609

wants to merge 23 commits into from

Conversation

XuehaiPan
Copy link
Collaborator

@XuehaiPan XuehaiPan commented Jun 23, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

cc @H-Huang @awgu @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k

@XuehaiPan
Update
0afb838 
[ghstack-poisoned]
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jun 23, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/156609

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 3 Pending

As of commit 9e1047a with merge base effe376 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/inductor oncall: distributed Add this issue/PR to distributed oncall triage queue labels Jun 23, 2025
This was referenced Jun 23, 2025
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@XuehaiPan XuehaiPan added topic: not user facing topic category better-engineering Relatively self-contained tasks for better engineering contributors labels Jun 23, 2025
@XuehaiPan
Update
7272edd 
[ghstack-poisoned]
XuehaiPan added a commit that referenced this pull request Jun 23, 2025
@XuehaiPan
[BE] fix typo in torch/distributed/tensor/: childs -> children
3b882f8 
ghstack-source-id: 005ee34
Pull-Request: #156609
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jun 24, 2025
@XuehaiPan
[BE] fix typo in torch/distributed/tensor/: childs -> children
e150658 
ghstack-source-id: 005ee34
Pull-Request: pytorch#156609
@XuehaiPan
Update
51cdfa4 
[ghstack-poisoned]
@XuehaiPan
Update
237c86b 
[ghstack-poisoned]
@XuehaiPan
Update
8e51d76 
[ghstack-poisoned]
XuehaiPan added a commit that referenced this pull request Jun 24, 2025
@XuehaiPan
[BE] fix typo in torch/distributed/tensor/: childs -> children
01c143e 
ghstack-source-id: a0db41b
Pull-Request: #156609
@XuehaiPan
Update
919d2e5 
[ghstack-poisoned]
XuehaiPan added a commit that referenced this pull request Jun 25, 2025
@XuehaiPan
[BE] fix typo in torch/distributed/tensor/: childs -> children
eca36e1 
ghstack-source-id: cba1d87
Pull-Request: #156609
@XuehaiPan
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 STARTUP failures reported, please check workflows syntax! Limited CI for distributed tests on H100

Details for Dev Infra team Raised by workflow job

@XuehaiPan
Update
488547c 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jul 8, 2025
@XuehaiPan
[BE] fix typo in torch/distributed/tensor/: childs -> children
2ab842d 
ghstack-source-id: c4a5721
Pull-Request: pytorch#156609
@XuehaiPan
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 STARTUP failures reported, please check workflows syntax! Limited CI for distributed tests on H100

Details for Dev Infra team Raised by workflow job

@XuehaiPan
Copy link
Collaborator Author

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 2 checks: inductor / unit-test / cuda12.8-py3.10-gcc9-sm86 / test (inductor_cpp_wrapper, 1, 2, linux.g5.4xlarge.nvidia.gpu), Limited CI for distributed tests on H100

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 STARTUP failures reported, please check workflows syntax! Limited CI for distributed tests on H100

Details for Dev Infra team Raised by workflow job

@XuehaiPan
Update
6122d99 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jul 9, 2025
@XuehaiPan
[BE] fix typo in torch/distributed/tensor/: childs -> children
5037ed5 
ghstack-source-id: eb187cb
Pull-Request: pytorch#156609
@XuehaiPan
Update
9e1047a 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jul 9, 2025
@XuehaiPan
[BE] fix typo in torch/distributed/tensor/: childs -> children
70851ec 
ghstack-source-id: 3813805
Pull-Request: pytorch#156609
@pytorchmergebot
Copy link
Collaborator

Starting merge as part of PR stack under #157636

pytorchmergebot pushed a commit that referenced this pull request Jul 9, 2025
@XuehaiPan @pytorchmergebot
[BE][2/6] fix typos in test/ (test/test_*.py) (#157636)
fc0376e 
Pull Request resolved: #157636
Approved by: https://github.com/yewentao256, https://github.com/mlazos
ghstack dependencies: #156311, #156609
@github-actions github-actions bot deleted the gh/XuehaiPan/331/head branch August 9, 2025 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wanchaol wanchaol wanchaol approved these changes

@cyyever cyyever cyyever approved these changes

@fegin fegin Awaiting requested review from fegin

@kwen2501 kwen2501 Awaiting requested review from kwen2501

Assignees
No one assigned
Labels
better-engineering Relatively self-contained tasks for better engineering contributors ciflow/h100-distributed ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged oncall: distributed Add this issue/PR to distributed oncall triage queue open source topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@XuehaiPan @ezyang @pytorchmergebot @wanchaol @cyyever @pytorchbot