Skip to content

[BE] fix typo: inpt -> input #157361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from

Conversation

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Jul 1, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/157361

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 049436a with merge base 38757d9 (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jul 1, 2025
ghstack-source-id: c6ff163
Pull-Request: pytorch#157361
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jul 2, 2025
ghstack-source-id: f0e2888
Pull-Request: pytorch#157361
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jul 3, 2025
ghstack-source-id: bdc9c23
Pull-Request: pytorch#157361
@XuehaiPan XuehaiPan added better-engineering Relatively self-contained tasks for better engineering contributors topic: not user facing topic category labels Jul 3, 2025
[ghstack-poisoned]
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jul 6, 2025
ghstack-source-id: ce1e5b5
Pull-Request: pytorch#157361
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jul 6, 2025
ghstack-source-id: ce1e5b5
Pull-Request: pytorch#157361
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jul 6, 2025
ghstack-source-id: ce1e5b5
Pull-Request: pytorch#157361
Copy link
Contributor

@yewentao256 yewentao256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jul 8, 2025
ghstack-source-id: 1209120
Pull-Request: pytorch#157361
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jul 8, 2025
ghstack-source-id: 208db5d
Pull-Request: pytorch#157361
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why change all of this code? inpt is very valid for variable names

@ezyang
Copy link
Contributor

ezyang commented Jul 9, 2025

And in fact, it is typically to avoid shadowing input

@XuehaiPan
Copy link
Collaborator Author

Added inpt and inpts into dictionary instead.

@XuehaiPan XuehaiPan closed this Jul 9, 2025
@github-actions github-actions bot deleted the gh/XuehaiPan/341/head branch August 9, 2025 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
better-engineering Relatively self-contained tasks for better engineering contributors ciflow/inductor module: inductor oncall: distributed Add this issue/PR to distributed oncall triage queue open source release notes: distributed (fsdp) release notes category release notes: quantization release notes category topic: not user facing topic category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants