Skip to content

REL 0.23.1 release #17271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 27 commits into from
May 19, 2020
Merged

REL 0.23.1 release #17271

merged 27 commits into from
May 19, 2020

Conversation

adrinjalali
Copy link
Member

#17270 should be included as well.

Anything missing from the picked ones?

d b2b88d3ee4 MNT bump master version to 0.24.dev0 (#17121)
d 226e5c478d MNT Use Vt instead of V as returned by svd() (#17100)
d 2a5c22a6aa Delegate choice of final model to sub class in LinearModelCV  (#17099)
d 89fcef7ad2 MNT Removed duplicate method calls in pickle estimator test (#17152)
d c7a4bc9b3a TST Replace Boston dataset in test_validation (#17146)
d e2256c111d TST Replace Boston dataset in test_coordinate_descent.py (#17153)
d 77279d6b3e Common check for sample weight invariance with removed samples (#16507)
d 818e16a1ea Revert "Common check for sample weight invariance with removed samples (#16507)"
d 192109af3d MNT properly activate the env in the linting CI (#17177)
d 4f5384b249 MNT Remove class support check estimator and parametrize_with_checks (#17134)
d a6a20f29d7 MNT fix test for binary crossentropy in hist-GBDT (#16691)
p 350b865e98 DOC Add treelite to related projects (#17166)
d b4e215c01c FEA Additional `TimeSeriesSplit` Functionality  (#13204)
p a4dcada715 DOC add an example in docstring of OneVsOneClassifier (#16700)
d d1f8a16ef8 MAINT change default value for min/max of IterativeImputer (#16493)
d d40d993199 CLN Refactors _encode into two functions (#17101)
d 4b92a775db MNT Cleaner cythn cdef loss function in SGD (#17191)
p cbe9f08e35 MNT Put back and properly deprecate MaskedArray (#17199)
p ccf5c36503 FIX don't modify sample weight inplace in KMeans (#17204)
p 5f9555b3ea FIX changed_only=True with kwargs parameters (#17205)
p 7316a1975c DOC fix typo in 0.22 and 0.23 whats new files (#17211)
d 7117a63137 MNT Removes voting classifer mention (#17196)
p 85d24b3cb5 pyproject.toml: Update numpy dependency on PyPy to 1.14.0 (#17215)
d 78a213b42c DOC use Ames housing for transformed_target example (#16741)
d 8abe0a822e MNT Replaced kwargs by named args for train_test_split (#17216)
p bbab854ff4 FIX Fix path to what's new in the navigation bar. (#17223)
p ca344be700 DOC Removes duplicate this in the release history. (#17220)
p 8595fe438c DOC Fix argument ref in Isomap docs (#17217)
p 3510a79263 DOC Fix formating in docstrings _regression.py (#17226)
p 90d00daa76 FIX Number of threads in KMeans should not be bigger than number of chunks (#17210)
p 350438cc4f MNT Add threadpoolctl in show_versions (#17241)
p 05e4c92d46 DOC update whatsnew_0.23 with removal of _safe_tags() (#17245)
d b0cd595536 MNT Ignore xfail_checks tag in check_estimator, with warning (#17222)
d d03dfa2778 MNT Removed name parameter from private check generators (#17224)
d 9d677b56f4 DOC Fix and extend mixed dtype column transformer example (#17088)
p b70472bd24 DOC correct estimator name in example (#17239)
p a4b59c793a DOC fix links in truncated SVD docs (#17194)
p 0db5f36f96 ENH Move threadpoolctl outside of iteration loop in KMeans (#17235)
p 0ba19ad2d8 MNT Fix incorrect source code link for wrapped objects (#17247)
d b6e839cb67 CLN Remove duplicate line (#17254)
d f58c2bc2df FEA Add staged_predict to HistGradientBoosting (#16985)
p a49752375d DOC Update plot_column_transformer to notebook style (#17028)
p 89d9729a4d DOC Add explanation of why iterative imputer is experimental (#17115)
d 60de458095 DOC Removes uneeded __init__ in API documentation (#17243)
d 1986c89a12 DOC exchange Boston for Diabetes at plot model complexity influence (#16533)
d 30788de8be DOC Use california data in compose.rst (#16871)
d f2e873f41e FIX/ENH CheckingClassifier support parameters and sparse matrices (#17259)
p 29f83f83f2 DOC Fix parametrize_with_checks link (#17263)
p 79b0943de0 DOC avoid FutureWarnings for deprecations examples (#17264)
p 43c0efa1b9 BUG Fixes cython code for ppc arch (#17201)

ping @scikit-learn/core-devs

NicolasHug and others added 24 commits May 18, 2020 18:56
@NicolasHug @adrinjalali
DOC Add treelite to related projects (scikit-learn#17166)
87768e7
@j0rd1smit @adrinjalali
DOC add an example in docstring of OneVsOneClassifier (scikit-learn#1…
28b9e39 
…6700)
@NicolasHug @adrinjalali
MNT Put back and properly deprecate MaskedArray (scikit-learn#17199)
e9bb004
@jeremiedbb @adrinjalali
FIX don't modify sample weight inplace in KMeans (scikit-learn#17204)
2d29057
@NicolasHug @adrinjalali
FIX changed_only=True with kwargs parameters (scikit-learn#17205)
e6c5cc8
@ogrisel @adrinjalali
DOC fix typo in 0.22 and 0.23 whats new files (scikit-learn#17211)
84b03b2 
* Typo

* Typo in v0.22.rst
@jvesely @adrinjalali
pyproject.toml: Update numpy dependency on PyPy to 1.14.0 (scikit-lea…
c978730 
…rn#17215)
@alfaro96 @adrinjalali
FIX Fix path to what's new in the navigation bar. (scikit-learn#17223)
8504023
@alfaro96 @adrinjalali
DOC Removes duplicate this in the release history. (scikit-learn#17220)
56bc338
@AdamSpannbauer @adrinjalali
DOC Fix argument ref in Isomap docs (scikit-learn#17217)
ee9a374
@lucyleeow @adrinjalali
DOC Fix formating in docstrings _regression.py (scikit-learn#17226)
99afd0f
@jeremiedbb @adrinjalali
FIX Number of threads in KMeans should not be bigger than number of c…
745d741 
…hunks (scikit-learn#17210)

* num threads not bigger than num chunks

* what's new
@jeremiedbb @adrinjalali
MNT Add threadpoolctl in show_versions (scikit-learn#17241)
2a1640a
@rtavenar @adrinjalali
DOC update whatsnew_0.23 with removal of _safe_tags() (scikit-learn#1…
711f1b0 
…7245)
@gio8tisu @adrinjalali
DOC correct estimator name in example (scikit-learn#17239)
96004e9
@NicolasHug @adrinjalali
DOC fix links in truncated SVD docs (scikit-learn#17194)
4163a53
@jeremiedbb @adrinjalali
ENH Move threadpoolctl outside of iteration loop in KMeans (scikit-le…
26b5151 
…arn#17235)
@alfaro96 @adrinjalali
MNT Fix incorrect source code link for wrapped objects (scikit-learn#…
b5e8495 
…17247)
@lucyleeow @adrinjalali
DOC Update plot_column_transformer to notebook style (scikit-learn#17028
3469a47 
)
@skeller88 @adrinjalali
DOC Add explanation of why iterative imputer is experimental (scikit-…
6069874 
…learn#17115)
@rth @adrinjalali
DOC Fix parametrize_with_checks link (scikit-learn#17263)
1ff07f9
@adrinjalali
DOC avoid FutureWarnings for deprecations examples (scikit-learn#17264)
f0982d3 
* MNT keyword only in examples

* MNT pandas 1.0.0 deprectation

See pandas-dev/pandas#23566

* MNT new keyword in 0.23
@thomasjpfan @adrinjalali
BUG Fixes cython code for ppc arch (scikit-learn#17201)
6085bb0 
* BUG Fixes cython in splitting

* REV Revert

* Revert "REV Revert"

This reverts commit d1cf3b1.

* WIP Uses signed char

* WIP Maybe use signed chars

* WIP const signed chars
@adrinjalali
MNT bump version to 0.23.1
0901cd8
@thomasjpfan
Copy link
Member

There are some public functions that we did not update with _deprecate_positional_args. I am currently working on a PR to address this.

@adrinjalali
Copy link
Member Author

@thomasjpfan any ETA? Should we then release tomorrow, or is your pr coming any time now? ;)

(no rush, I'm happy with releasing tomorrow)

@thomasjpfan
Copy link
Member

The PR is here: #17271

It also lists all other public functions that we missed to see if we want to add a * in the function signature.

@jeremiedbb
Copy link
Member

I think #17273 should be included. The dependencies are not up to date on the web site.

@NicolasHug
Copy link
Member

Should

p a49752375d DOC Update plot_column_transformer to notebook style (#17028)

be picked? I don't mind, I'm just wondering of what are the rules for bugfix releases. Like, other example-related PRs weren't cherry picked.

@alfaro96 @adrinjalali
DOC Add threadpoolctl requirement to documentation (scikit-learn#17273)
e5bdfba 
* MNT Add threadpoolctl dependency to README.rst

* MNT Add threadpoolctl dependency to advanced installation instructions
@adrinjalali
Copy link
Member Author

@jeremiedbb thanks for the ping, included.

@NicolasHug I tried to include the doc changes which were mostly formatting or minor, but not the ones which were a bit more "major", like changing the dataset used in the example. I'm happy to revert that one if you think it's not a consistent policy.

@adrinjalali
Copy link
Member Author

will wrap this up tomorrow, including #17272 (feel free to continue the process if you think it's urgent)

@thomasjpfan @adrinjalali
MNT Completes position arg deprecation (scikit-learn#17272)
32c99c4 
* ENH Adds public functions with position args warning

* BUG Circlar import

* STY

* BUG Add keywords

* BUG Fixes warnings

* ENH Adds other public functions

* CLN Suggestion

* CLN Suggestion

* REV Revert pairwise

* ENH Positoinal args for compute_class_weight
@adrinjalali adrinjalali merged commit fd23727 into scikit-learn:0.23.X May 19, 2020
@adrinjalali adrinjalali deleted the 0.23.1 branch May 19, 2020 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
module:cluster
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.