Allow custom transports for mailer component #31935
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have done the same a few hours ago in #31931 :/ (but not really the same way) |
|
@kevin-verschaeve Sorry, did not see your PR. I'll review it. |
3 tasks
|
Thanks for the PR. I think I prefer something that allows third party to implement a mailer provider with the same "feel" as built-in ones (with a proper DSN). That's what #31946 implements. |
fabpot
added a commit
that referenced
this pull request
Jul 17, 2019
…stom transports (Koc) This PR was merged into the 4.4 branch. Discussion ---------- [Mailer] Extract transport factory and allow create custom transports | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes, failure unrelated (master hasn't this PR) | Fixed tickets | #31385, #32523 | License | MIT | Doc PR | TBD Alternative approach to allow create custom transports and register DSN for it. Replaces #31931, #31935 . Similar to already existent TansportFactory from Messenger. TODO: - [x] Update changelog - [x] Add more tests for factories - [x] Add test for configuration + DI extension Commits ------- 5b9cded Add transport factories (closes #31385, closes #32523)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to define a custom transport for mailer component.
To enable it, set the
framework.mailer.dsnkey tonulland the newframework.mailer.transport_idkey to the transport service id you want to inject into the default mailer instance.