-
-
Notifications
You must be signed in to change notification settings - Fork 25.8k
Add links to examples from the docstrings and user guide #30621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Leaving a comment so I get updates about incoming PRs :) |
Commenting to stay updated! |
Hi Sklearn Team, excited to work on this on this issue. I will be following the workflow and start working on this. Its my first time contributing to sklearn, hence hoping I learn as much as possible and also contribute to the open source community! I will be working on examples/classification: Updated: Hi @StefanieSenger, I have found few places, where I can place examples from SVM in the User Guide. Is it okay, to select a group of this size and work on this in a single PR? (from review perspective) |
Hey team! |
Hi @sarang-26, nice to hear you want to contribute. |
Working on |
Hi, I'd like to work on adding references for |
Awesome! Happy to see your contribution. |
Hi @StefanieSenger! |
Hello @StefanieSenger I am looking for open-source contributions. This will be my first contribution, I would like to work on file Thank you! |
Hello @StefanieSenger I am quite new to open-source contributions. I would like to work on examples/model_selection/plot_cv_predict.py. Thank you |
Hello @StefanieSenger Thank you! |
Hi @sarang-26, I'd say that's too many. Please split it up or go one by one. |
Hello @StefanieSenger I am quite new to open-source contributions. I would like to work on Thank you! |
Hi! I have created a pull request: #30650 . It adds a reference to the |
Hi @StefanieSenger, I'm new to open source contributions, I was wondering if I could work on:
Thank you, |
Hello! I'd like to claim this example as my first contribution: scikit-learn/examples/mixture/plot_concentration_prior.py Thanks! |
Hello @StefanieSenger, This will be my first contribution to scikit-learn. Thank you! |
Hello @StefanieSenger, I would still love to contribute, so I’d like to switch to plot_ols_ridge_variance.py if it’s still available. Thanks for your patience. |
That's an excellent finding, thank you, @sotagg! plot_ols_ridge_variance.py looks fine, but I didn't check in depth (that's on you again). |
Hi @StefanieSenger , I'd like to contribute to this issue by adding references to the following examples in the documentation: I have checked the comments and PRs and didn't find any related work for these files. Please confirm if I can proceed with these contributions. Thanks! |
Hi @StefanieSenger, Thank you, |
Hi @tarek7669, somebody has claimed plot_feature_selection.py on Jan 11th, but after 2 months have passed, you can take over. |
I will do examples/miscellaneous/plot_anomaly_comparison.py I have done some searching and I think all the places that would be useful for it to link to already have it. (I have not done an exhaustive search.) |
I will do plot_forest_importances.py |
Hello! I can try adding an entry for examples/cluster/plot_face_compress.py |
Hello @StefanieSenger, I would like to work on plot_feature_transformation.py |
Hi @StefanieSenger, The file examples/ensemble/plot_forest_importances.py is already properly referenced in doc/modules/feature_selection.rst (line 273) and doc/modules/ensemble.rst (line 1164). I didn’t find any other locations where additional references are needed. Feel free to check them off the list if everything looks good to you. |
Awesome, @marktemi. Thanks for your work. I have checked it off. |
Hi @StefanieSenger. I was looking at There are some sections about "Mutual Information" in doc/modules/clustering.rst (lines 1453 onwards). I am not sure if this example fits here too. If this is the case, let me know please. I will add it. Otherwise, we can just remove it from the list. |
Hi, I'd like to contribute by improving the documentation for |
Hi @elhambbi, yes I agree the one link is enough. I would not add this to the clustering.rst file since it's a regression example. Thus I have checked the example off the list. Thanks a lot for reporting back! |
Hi @StefanieSenger, I'd like to work on |
If the issue is still open, I'd like work on it. Kindly assign it to me. @StefanieSenger |
Hi, I would like to work on linking the example |
Hi @StefanieSenger! I'd like to work on adding documentation links for the following examples:
I've reviewed the discussion thread and confirmed that no one has claimed these examples recently, nor do they appear to have any associated PRs or "in progress" markers. Please let me know if there are any specific considerations I should keep in mind while working on these examples. Thank you! |
Hi @StefanieSenger, I would like to work on 'plot_gmm_covariances.py'. |
Hi @StefanieSenger - would like to take - |
Hey @StefanieSenger, |
Hello @StefanieSenger, I would like to contribute for the first time and add a documentation link for the Thank you! |
This is intended to add a link to the Non-negative least squares example in the LimearRegression API page. It is towards scikit-learn#30621. The following example is used: `plot_nnls.py` This example is linked in the User Guide for Linear Regression, but not anywhere on the API page.
Hello @StefanieSenger |
TLDR: Meta-issue for new contributors to add links to the examples in helpful places of the rest of the docs.
Description
This meta-issue is a good place to start with your first contributions to scikit-learn.
This issue builds on top of #26927 and is introduced for easier maintainability. The goal is exactly the same as in the old issue.
Here, we improve the documentation by making the Examples more discoverable by adding links to examples in relevant sections of the documentation in the API documentation and in the User Guide:
sklearn
folder of the projectdoc/modules
folder of the projectTogether with the examples (which are in the
examples
folder of the project), these files get rendered into html when the documentation is build and then are displayed on the scikit-learn website.Important: We estimate that only 70% of the examples in this list will ultimately be referenced. This means part of the task is deciding which examples deserve being referenced and we are aware that this is not a trivial decision, especially for new contributors. We encourage you to share your reasoning, and a team member will make the final call. We hope this isn’t too frustrating, but please know that evaluating an example is not just an exercise for new contributors; it’s a meaningful and valuable contribution to the project, even (and especially) if the example you worked on doesn’t end up being linked.
Workflow
We recommend this workflow for you:
have
pre-commit
installed in your environment as in point 10 of How to contribute in the development guide (this will re-format your contribution to the standards used in scikit-learn and will spare you a lot of confusion when you are a beginner)pick an example to work on
plot_...
); b) use full text search of your IDE to look for where that name appearsfind suitable spots in either the API documentation or the User Guide (or both) where users would be happy to find your example linked
See Also
section, which is (theoretically) reserved for links to other API functionalities, not examplesadd links
.. rubric:: Examples
section to put the example if possible, but to integrate it into the text; be aware that if you add a link like this :ref:`title <link>`, you can change its title so that the example's title gets substituted by your picked title and the link can be fitted more nicely to the sentences.. rubric:: Examples
sectiontest build the documentation before opening your PR
open PR
DOC add links to <name of example>
(starting with DOC)#30621
" (do not use "Closes #..." or "Fixes #...")check the CI
auto_examples/path_to_example, [dev], [stable]
, where the first link is your branche's version, the second is the main dev branch and the third link is the last released scikit-learn version that is used for the stable documentation on the website.pre-commit
properly, and fix the issue by the action the CI proposes (for instance adding or deleting an empty line)git commit --allow-empty -m "empty commit to re-trigger CI"
)wait for reviews and be ready to adjust your contribution later on
Expectation management for new contributors
How long will your first PR take you up until the point you open a PR?
How long will it take us to merge your PR?
ToDo
Here's a list of all the remaining examples:
model complexity influence
#30814plot_validation_curve.py#had been merged with another example in DOC merge example presenting the concept of validation curve #29936[x] plot_tree_regression_multioutput.py# was merged with another example in DOC Add link to plot_tree_regression.py example #26962What comes next?
help wanted
label or with themoderate
label or you can take over stalled PRs; these kind of contributions need to be discussed with maintainers and I would recommend seeking their approval first and not invest too much work before you get a goThe text was updated successfully, but these errors were encountered: