Skip to content

Various L4 and WB fixes, take 4 #578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Various L4 and WB fixes, take 4 #578

wants to merge 4 commits into from

Conversation

David-OConnor
Copy link
Contributor

@David-OConnor David-OConnor commented Jun 21, 2021

Fixes #555, #563, #565, #567, #570, #572, and #575.

See #577; "unrecoverable" git errors.

Not currently working:

  • Last 3 (by address) added L412 RTC regs are not adding
  • WB HSEM and IPCC renamed regs are not changing

@github-actions
Copy link

Memory map comparison

@David-OConnor
Copy link
Contributor Author

David-OConnor commented Jun 24, 2021

Also removed the L4x2 USB_FS rename to USB: the RM calls it USB_FS. Previous justification, from a code comment:

we call the resulting peripheral USB instead of USB-FS to be aligned with mvirkkunen/stm32f103-usb

The peripheral is called USB; the interrupt is called USB_FS.

@David-OConnor David-OConnor mentioned this pull request Jun 24, 2021
@David-OConnor
Copy link
Contributor Author

Broke git again

bors bot added a commit that referenced this pull request Aug 18, 2021
580: L4 and WB fixes r=adamgreig a=David-OConnor

Fixes #555, #563, #565, #567, #570, #572, and #575.

See #578; "unrecoverable" git errors.

Not currently working:

- Last 3 (by address) added L412 RTC regs are not adding
- WB HSEM and IPCC renamed regs are not changing
- BCDR field added to USB

Removed the L4x2 `USB_FS` rename to `USB`: the RM calls it `USB_FS`. Previous justification, from a code comment: 
> we call the resulting peripheral `USB` instead of `USB-FS` to be aligned with `mvirkkunen/stm32f103-usb`

The *peripheral* is called `USB`; the interrupt is called `USB_FS`.

Co-authored-by: David O'Connor <david.alan.oconnor@gmail.com>
Co-authored-by: Adam Greig <adam@adamgreig.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

L41x and L42x use diff RTC regs
1 participant