Skip to content

L4 and WB fixes #580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Aug 19, 2021
Merged

L4 and WB fixes #580

merged 16 commits into from
Aug 19, 2021

Conversation

David-OConnor
Copy link
Contributor

@David-OConnor David-OConnor commented Jun 24, 2021 •
edited
Loading

Fixes #555, #563, #565, #567, #570, #572, and #575.

See #578; "unrecoverable" git errors.

Not currently working:

  • Last 3 (by address) added L412 RTC regs are not adding
  • WB HSEM and IPCC renamed regs are not changing
  • BCDR field added to USB

Removed the L4x2 USB_FS rename to USB: the RM calls it USB_FS. Previous justification, from a code comment:

we call the resulting peripheral USB instead of USB-FS to be aligned with mvirkkunen/stm32f103-usb

The peripheral is called USB; the interrupt is called USB_FS.

@David-OConnor David-OConnor changed the title L4 and WB fixex L4 and WB fixes Jun 24, 2021
@David-OConnor
Copy link
Contributor Author

Of note, re the USB_FS change on L4x2. Unable to get the module to compile with that rename removed. Eg USB_FS: USB_FS { in mod.rs: "not found in this scope for the last". I can revert the change, or maybe there's a way to fix it and keep the _FS name for the interupt.

@David-OConnor
Copy link
Contributor Author

All issues I posted about are fixed. Thanks @adamgreig!

@David-OConnor
L4 and WB fixes
07d3656 
Added L412

Updated USB_FS interrupt change logic on L4x2 and L412

Fixed last 3 RTC regs on L412 not adding due to bkpr regs not being deleted

Fixed WB IPCC and HSEM reg naming
@David-OConnor
Merge branch 'l4_wb_fixes_attempt' of https://github.com/david-oconno…
0f5e7dd 
…r/stm32-rs into l4_wb_fixes_attempt
@David-OConnor
removed note on 4x3 about BCDR add not workign
7eb26ef
@David-OConnor David-OConnor marked this pull request as draft July 5, 2021 00:25
@David-OConnor David-OConnor marked this pull request as ready for review July 5, 2021 00:29
@David-OConnor David-OConnor marked this pull request as draft July 5, 2021 00:37
@David-OConnor David-OConnor marked this pull request as ready for review July 5, 2021 00:40
adamgreig
adamgreig approved these changes Aug 18, 2021
View reviewed changes
Copy link
Member

@adamgreig adamgreig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@David-OConnor thanks for this PR! I've made a few tweaks in the recent commits, mainly:

  • some bits were wrong in the TIM16/TIM17 fixes for WB55
  • you can use _split to break a wide field into lots of individual bits, without having to write them all out
  • (so I applied it to the other similar fields in WB55 EXTI too)
  • I refactored the L4x2 and L412 common patches into a separate file so they can't drift apart

bors merge

@bors
Copy link
Contributor

bors bot commented Aug 19, 2021

Build succeeded:

@bors bors bot merged commit a02b1a8 into stm32-rs:master Aug 19, 2021
This was referenced Aug 19, 2021
Closed
Closed
Closed
Closed
This was referenced Aug 19, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamgreig adamgreig adamgreig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

L41x and L42x use diff RTC regs
2 participants
@David-OConnor @adamgreig