Skip to content

ListenerInterface deprecated since Symfony 4.3 #12780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 729 commits into from

Conversation

JohnyProkie
Copy link
Contributor

Symfony\Component\Security\Http\Firewall deprecation comment:

  • @deprecated since Symfony 4.3, turn listeners into callables instead

I saw this in Symfony5 docs as well, should I create separate PRs for respective branches?

javiereguiluz and others added 30 commits September 26, 2019 08:40
… access_control rules (javiereguiluz)

This PR was merged into the 4.4 branch.

Discussion
----------

[Security] Deprecated using more than one role in access_control rules

Fixes symfony#12363.

Commits
-------

19475ed [Security] Deprecated using more than one role in access_control rules
* 4.3:
  Add a warning to imports order
* 4.3:
  Update routing.rst
* 4.3:
  Adding a sample tsconfig file to the Encore documentation page
* 4.3:
  [Messenger] `get()` usage
* 4.3:
  [Logger] [Processor] additional info on processor
* 4.3:
  Adding instructions to prevent CORS errors
* 4.3:
  Update api_key_authentication.rst
* 4.3:
  Clarify target path functionality
* 4.3:
  Add docs for DateTimeZoneNormalizer
* 4.3:
  Extend framework lock configuration reference
* 4.3:
  Add flock:// option to framework lock configuration reference
…y_string (javiereguiluz)

This PR was squashed before being merged into the 4.4 branch (closes symfony#12050).

Discussion
----------

[Ldap] Documented the deprecation related to query_string

I need help to come up with a good value for the `search_dn` option in this example.

Also, should we mention this in the other place where we talk about `query_string`? Here: https://symfony.com/doc/current/reference/configuration/security.html#query-string

Thanks.

Commits
-------

382c5c8 [Ldap] Documented the deprecation related to query_string
* 4.3:
  ISSUE-12195: - Added documentation about how to autowire monolog channels.
* 4.3:
  Minor fixes
…ators (ostrolucky)

This PR was merged into the 4.4 branch.

Discussion
----------

Document new ProgressBar time-based frequency mutators

Fixes symfony#11915

Commits
-------

8a5b08d Document new ProgressBar time-based frequency mutators
* 4.3:
  [symfony#10824] Applied some of @HeahDudes comments and added missing comments
  [symfony#10824] Fixed issues found by DOCtor
  [DependencyInjection] Fluent PHP DI Documentation
* 4.3:
  Add more information about Docker and the local web server
* 4.3:
  Fixed typo
* 4.3:
  Fixes broken links to source code on github.com
…te spaces (javiereguiluz)

This PR was merged into the 4.4 branch.

Discussion
----------

Documented the DomCrawler option to normalize white spaces

Fixes symfony#12388.

Commits
-------

9556e4c Documented the DomCrawler option to normalize white spaces
…(JustBlackBird)

This PR was merged into the 4.4 branch.

Discussion
----------

[DomCrawler] Add hint about Form::getName method

This PR describes some use cases of `Symfony\Component\DomCrawler\Form::getName` method

Commits
-------

c8a6ec5 [DomCrawler] Add hint about Form::getName method
…PUnitBridge (jderusse)

This PR was merged into the 4.4 branch.

Discussion
----------

Add documentation for polyfill provided by the PHPUnitBridge

Provides documentaiton for the new features of PHPUnitBridge

Fixes symfony#12092

Commits
-------

d1e0bae Add documentation for polyfill provided by the PHPUnitBridge
wouterj and others added 22 commits December 1, 2019 15:00
* 4.3:
  Update impersonating_user.rst
  Small typo in workflow.rst
…nvx)

This PR was merged into the 4.4 branch.

Discussion
----------

[DependencyInjection] Bind tagged services

Update documentation for https://symfony.com/blog/new-in-symfony-4-4-dependency-injection-improvements-part-1#allow-binding-tagged-services

NOTE: this documentation require symfony/symfony#34732 to be merged

Commits
-------

7ec6d9d [DependencyInjection] Bind tagged services
… (wouterj)

This PR was merged into the 4.4 branch.

Discussion
----------

[Security] Added article on password migrations

Fixes symfony#12395, symfony#12612

Please note that I did not yet test the code examples in this article.

#SymfonyHackathon

Commits
-------

0de1588 Added article on password migrations
* 4.3:
  Update parent_services.rst
  Fix documentation for PhpUnitBridge regex configuration
This PR was squashed before being merged into the 4.4 branch (closes symfony#12725).

Discussion
----------

Update mailer.rst

Commits
-------

627ec43 Update mailer.rst
… (Matthieu Lempereur, MrYamous)

This PR was merged into the 4.4 branch.

Discussion
----------

Add documentation for exponential format number

PR for issue symfony#12537

Adding basic documentation in 4.4 for Exponential format number

Commits
-------

79160c8 Add versionadded in file
7146962 Add documentation for exponential format number
* 4.3:
  Added note regarding workflow "entered" event being dispatched on creation
This PR was merged into the 4.4 branch.

Discussion
----------

Document: get/setThrowable

Fixes symfony#12615
Fixes symfony#12716

Commits
-------

37a5f1e get/setThrowable
…terface (JohJohan)

This PR was merged into the 4.4 branch.

Discussion
----------

Fix typo PersistStoreInterface to PersistingStoreInterface

<!--

If your pull request fixes a BUG, use the oldest maintained branch that contains
the bug (see https://symfony.com/roadmap for the list of maintained branches).

If your pull request documents a NEW FEATURE, use the same Symfony branch where
the feature was introduced (and `master` for features of unreleased versions).

-->

Commits
-------

74ad034 Update lock.rst
* 4.3:
  *Response::create() method is deprecated
…(pableu)

This PR was merged into the 4.4 branch.

Discussion
----------

Fix a typo in mailer docs (Mutliple -> Multiple)

Commits
-------

b281628 fix a typo in mailer docs (Mutliple -> Multiple)
* 4.3:
  [Cache] Fixed a minor RST syntax issue
  [Cache] Expand the docs about the cache chain
  Explain the prefix used for expressions in YAML files
  Minor tweak in a security expression explanation
* 4.3:
  Removed 4.4 versionadded from the 4.3 docs
  Update setup.rst
  Update messenger.rst
Symfony\Component\Security\Http\Firewall deprecation comment:

* @deprecated since Symfony 4.3, turn listeners into callables instead
@OskarStark
Copy link
Contributor

OskarStark commented Dec 8, 2019

No this is not needed, we will do the upmerge.
But please target 4.3 then, thanks

@JohnyProkie JohnyProkie changed the base branch from 4.4 to 4.3 December 8, 2019 20:22
JohnyProkie added a commit to JohnyProkie/symfony-docs that referenced this pull request Dec 8, 2019
Symfony\Component\Security\Http\Firewall deprecation comment:

    @deprecated since Symfony 4.3, turn listeners into callables instead

Targeting 4.3 branch as per @OskarStark comment in original PR symfony#12780 (comment)
@JohnyProkie
Copy link
Contributor Author

New PR #12781
Sorry, messed this up.

@JohnyProkie JohnyProkie closed this Dec 8, 2019
javiereguiluz added a commit that referenced this pull request Dec 9, 2019
…kie)

This PR was merged into the 4.3 branch.

Discussion
----------

ListenerInterface deprecated since Symfony 4.3

Symfony\Component\Security\Http\Firewall deprecation comment:

    @deprecated since Symfony 4.3, turn listeners into callables instead

Targeting 4.3 branch as per @OskarStark comment in original PR #12780 (comment)

Commits
-------

6784ec4 ListenerInterface deprecated since Symfony 4.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.