[FrameworkBundle] add config translator cache_dir #32543
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ixx) This PR was merged into the 4.4 branch. Discussion ---------- [ServerBundle] Display all logs by default | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony#32111 | License | MIT | Doc PR | Instead of relying on `-vvv` behavior, we display all logs. End user has two ways of filtering now: * with the `--filter` options * by configuring the handler in `config/dev/monolog.yaml` Commits ------- 54b0809 [ServerBundle] Display all logs by default
…e::clear() (nicolas-grekas) This PR was merged into the 4.4 branch. Discussion ---------- [Cache] Add argument $prefix to AdapterInterface::clear() | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - This PR allows clearing `AdapterInterface` implementations by prefix of keys. The goal is to fix an edge case situation in `ProxyAdapter`: right now, when one calls `->clear()` on a proxy adapter that is configured to add a prefix to all the keys passed to the decorated pool, we clear it all; while only the subset that starts with the prefix should be. Since `AdapterInterface` is an "internal" interface (ie its purpose is to create compatible implementations - *NOT* to be type-hinted for), this is not really a user-facing change. /cc @Nyholm, this came out after we talked about proxified chain pools Commits ------- ad6f6cf [Cache] Add argument $prefix to AdapterInterface::clear()
…rror instead info. Rebase of symfony#28462 (berezuev) This PR was merged into the 4.4 branch. Discussion ---------- [SECURITY] AbstractAuthenticationListener.php error instead info. Rebase of symfony#28462 | Q | A | ------------- | --- | Branch? | 4.4 | -- | -- | Bug fix? | yes | New feature? | no | BC breaks? | no I think | Deprecations? | no | Tests pass? | yes | Fixed tickets | ... | License | MIT Rebase of symfony#28462. Origin description: > ``` > [2018-09-13 20:43:38] security.INFO: Authentication request failed. {"exception":"[object] (Symfony\\Component\\Security\\Core\\Exception\\AuthenticationServiceException(code: 0): An exception occurred while executing > ... > Doctrine\\DBAL\\Driver\\PDOException(code: 42S22): SQLSTATE[42S22]: Column not found: 1054 Unknown column 't0.phone' in 'field list' at > ``` > > Definitely I think this is NOT info, but error. > And since it's info, it's not logged in production because of `fingers_crossed` with `action_level: error` - so to actually see the real error behind `Authentication request could not be processed due to a system problem.` I had to debug on production. Very bad practice IMHO. Commits ------- 867eb78 [SECURITY] AbstractAuthenticationListener.php error instead info. Rebase of symfony#28462
… of symfony local server (Simperfit) This PR was merged into the 4.4 branch. Discussion ---------- [WebserverBundle] Deprecate the bundle in favor of symfony local server | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | yes <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | none <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | to do <!-- required for new features --> <!-- Write a short README entry for your feature/bugfix here (replace this comment block.) This will help people understand your PR and can be used as a start of the Doc PR. Additionally: - Bug fixes must be submitted against the lowest branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the master branch. --> Since most of the feature added to the symfony local server (using php-fpm) will be handy for all developers and as said in symfony#25748 (comment), I agree that we should deprecate the WebserverBundle in favor of the [Symfony Local Server](https://symfony.com/doc/current/setup/symfony_server.html) cc @stof @fabpot Commits ------- 7307907 [WebserverBundle] Deprecate the bundle in favor of symfony local server
This PR was merged into the 4.4 branch. Discussion ---------- [Console] Added Application::reset() | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Symfony leaks a lot in CLI when using the EventDispatcher. I'm working on it. But instead of fixing the root cause, it can be legit to go quick and to reset all services. So IMHO, this services should be exposed, and always available Commits ------- 15ba579 [Console] Added Application::reset()
…very 100ms by default (nicolas-grekas) This PR was merged into the 4.4 branch. Discussion ---------- [Console] don't redraw progress bar more than every 100ms by default | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no (behavior change) | BC breaks? | no (behavior change) | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Follow up of symfony#26339 Looks like something we can and should do on 4.4 to me. Commits ------- df551e9 [Console] don't redraw progress bar more than every 100ms by default
This PR was merged into the 4.4 branch. Discussion ---------- [DI] deprecate booting the kernel twices | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | yes <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | symfony#31233 <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | ? <!-- required for new features --> <!-- Replace this notice by a short README for your feature/bugfix. This will help people understand your PR and can be used as a start for the documentation. Additionally (see https://symfony.com/roadmap): - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against branch 4.4. - Legacy code removals go to the master branch. --> This adds a check to see if the kernel has been booted twices in a single test, and throw a deprecation Commits ------- 905bec4 [DI] throw an exception when the kernel has been booted twices
…limits in range constraint (Lctrs) This PR was squashed before being merged into the 4.4 branch (closes symfony#31511). Discussion ---------- [Validator] Allow to use property paths to get limits in range constraint | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | Part of symfony#31503 | License | MIT | Doc PR | symfony/symfony-docs#11793 Similar as symfony#22576, but for the `Range` constraint. Commits ------- 2b50990 [Validator] Allow to use property paths to get limits in range constraint
This PR was merged into the 4.4 branch. Discussion ---------- [Stopwatch] Fix missing deprecations | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | no needed Fix symfony#32408 Commits ------- 527bf89 Fix missing deprecations
…erfaces with less responsability (Simperfit) This PR was squashed before being merged into the 4.4 branch (closes symfony#32198). Discussion ---------- [Lock] Split "StoreInterface" into multiple interfaces with less responsability | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | yes <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | Contribute to symfony#28694 <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | TODO <!-- required for new features --> <!-- Replace this notice by a short README for your feature/bugfix. This will help people understand your PR and can be used as a start for the documentation. Additionally (see https://symfony.com/roadmap): - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against branch 4.4. - Legacy code removals go to the master branch. --> We are removing the StoreInterface in order to split into multiple interface, it will help reduce de responsability of the StoreInterface. Firstly, since not all stores needs to have all the methods of the StoreInterface, we can split this like this in order to limit the methods that are needed for each store. Secondly, we add supportsX methods in order to avoid throwing exception when a store does not supports a feature it's easier an instance of the special interface or not, and it can return true/false on the support method. **Really big thanks to** @jderusse for working with me on this, 1-2 hours of talking together, and another 1-2 hours of pre-review :). now giving it to the whole community ! *some time has been sponsored by* @izisolutions Commits ------- 91fcbea [Lock] Split \"StoreInterface\" into multiple interfaces with less responsability
…ch on double CMD/CTRL + F (ogizanagi) This PR was merged into the 4.4 branch. Discussion ---------- [VarDumper] Let browsers trigger their own search on double CMD/CTRL + F | Q | A | ------------- | --- | Branch? | 4.4 <!-- see below --> | Bug fix? | no | New feature? | yes <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | symfony#29748 <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A Simple way to enhance DX & mitigate symfony#29748 Commits ------- d243058 [VarDumper] Let browsers trigger their own search on double CMD/CTRL + F hit
This PR was merged into the 4.4 branch. Discussion ---------- [Lock] Fix tests | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | nno <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | none <!-- required for new features --> <!-- Replace this notice by a short README for your feature/bugfix. This will help people understand your PR and can be used as a start for the documentation. Additionally (see https://symfony.com/roadmap): - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against branch 4.4. - Legacy code removals go to the master branch. --> cc @fabpot fix lock tests. Commits ------- 2c5089b [Lock] Fix tests
…ponent (1st step) (yceruto) This PR was squashed before being merged into the 4.4 branch (closes symfony#32377). Discussion ---------- [Debug] Restoring back the state of the Debug component (1st step) | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | symfony#32371 | License | MIT After a good discussion with @nicolas-grekas, we made the decision to split the current `ErrorCatcher` component into several: * `ErrorHandler` it would be the Debug component before these changes symfony#31065, with everything related to ErrorHandler, Debug, DebugClassLoader classes and change its name. * `ErrorDumper` it would be the current ErrorCatcher but with FlattenException + the new error renderer system only. This is the first step, then we can deprecate everything for the Debug component in favor of the ErrorHandler and ErrorDumper components, **BUT without moving any code !!**, that would give us more freedom to do it correctly in the new components. NOTE: For this PR I've copy the `Debug` component directory from the revision prior to merged commit symfony#31065 in 4.4 branch. Commits ------- eda49e2 [Debug] Restoring back the state of the Debug component (1st step)
This PR was squashed before being merged into the 4.4 branch (closes symfony#31975). Discussion ---------- Dynamic bundle assets | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | BC breaks? | no (new method in interface as annotation) | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony#29213 | License | MIT | Doc PR | none (yet) Everything is explained in linked issue Commits ------- c16fcc9 Dynamic bundle assets
…ctory (Simperfit) This PR was merged into the 4.4 branch. Discussion ---------- [Lock] rename and deprecate Factory into LockFactory | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | yes<!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | none <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR <!-- required for new features --> <!-- Replace this notice by a short README for your feature/bugfix. This will help people understand your PR and can be used as a start for the documentation. Additionally (see https://symfony.com/roadmap): - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against branch 4.4. - Legacy code removals go to the master branch. --> As highlighted in symfony#32198 (review) we need to rename the factory to LockFactory for consistency and readability. Commits ------- fc75eb9 [Lock] rename and deprecate Factory into LockFactory
…nterface (Simperfit) This PR was merged into the 4.4 branch. Discussion ---------- [Lock] minor: add missing alias for PersistStoreInterface | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | none <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | todo <!-- required for new features --> <!-- Replace this notice by a short README for your feature/bugfix. This will help people understand your PR and can be used as a start for the documentation. Additionally (see https://symfony.com/roadmap): - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against branch 4.4. - Legacy code removals go to the master branch. --> Add missing alias highlited by @jderusse in order to do: ``` public function __construct(PersistStoreInterface $store) {} ``` Commits ------- f1e98f2 [Lock] minor: add missing alias for PersistenStoreInterface
…(Simperfit) This PR was merged into the 4.4 branch. Discussion ---------- [Lock][Console] bump lock requirement in console | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? |no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | not needed <!-- required for new features --> <!-- Replace this notice by a short README for your feature/bugfix. This will help people understand your PR and can be used as a start for the documentation. Additionally (see https://symfony.com/roadmap): - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against branch 4.4. - Legacy code removals go to the master branch. --> Fix test of the console component, by bumping the lock requirement Commits ------- 41de633 [Lock][Console] bump lock requirement in console
…ntainsString*() (Tobias Weichart) This PR was merged into the 4.4 branch. Discussion ---------- [PhpUnitBridge] added polyfill for assertStringContainsString*() | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony#32844 | License | MIT | Doc PR | - this PR provides a polyfill for methods assertStringContainsString and assertStringContainsStringIgnoringCase in preparation for the PHPUnit 9 deprecations. PR follows the pattern of [this PR](symfony#32869), hence the PR to master Commits ------- 1602441 [PhpUnitBridge] added polyfill for assertStringContainsString*()
…olas-grekas) This PR was merged into the 4.4 branch. Discussion ---------- [PhpUnitBridge] add more assert*() polyfills | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony#32844 | License | MIT | Doc PR | - Commits ------- 54ddfd2 [PhpUnitBridge] add more assert*() polyfills
…s (fabpot) This PR was merged into the 4.4 branch. Discussion ---------- [Mailer] Add debug info on HTTP transport exceptions | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | n/a | License | MIT | Doc PR | n/a Same as symfony#32896 but for HTTP transports. Commits ------- 4cfb4b9 [Mailer] added debug info on HTTP transport exceptions
* 4.3: symfony#32853 Check if $this->parameters is array. [Validator] Improve Fa translations
…tCase (jderusse) This PR was merged into the 4.4 branch. Discussion ---------- [PhpUnitBridge] Inject ForwardCompatibiliy in TestCase | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | not yet | Fixed tickets | symfony#32844 | License | MIT | Doc PR | NA This PR replace the previous trait `ForwardCompatTestTrait` by injecting forward compatibility code in phpunit itself which allow to use the polyfill methods in tests without changing the code. when using `simple_phpunit` the env variable `$PHPUNIT_REMOVE_RETURN_TYPEHINT=1` (default 0) removes the `: void` typehint in public and protected methods (allow to use 7.4 8 in 3.4 branch) note: once merged, all tests have to be fixed. see symfony#32889 Commits ------- 016bd8d Inject ForwardCompatibiliy in TestCase
* 4.3: Remove use of ForwardCompatTrait Remove deprecated methods assertArraySubset
* 4.3: Fix tests on console cs fix Fix path to phpunit binary [Yaml] PHP-8: Uncaught TypeError: abs() expects parameter 1 to be int or float, string given
This PR was merged into the 4.4 branch. Discussion ---------- [Yaml] Add flag to dump NULL as ~ | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#12071 This PR adds the ability to dump `null` as `~` by a new Flag `Yaml::DUMP_NULL_AS_TILDE`: ```diff - foo: null + foo: ~ ``` Todos: - [x] Fix/add tests Commits ------- 749c11d [Yaml] Add flag to dump NULL as ~
fabpot
approved these changes
Aug 4, 2019
26048b2 to
7613c7d
Compare
|
Thank you @Raulnet. |
fabpot
added a commit
that referenced
this pull request
Aug 4, 2019
…lnet) This PR was submitted for the 4.3 branch but it was squashed and merged into the 4.4 branch instead (closes #32543). Discussion ---------- [FrameworkBundle] add config translator cache_dir | Q | A | ------------- | --- | Branch? | 4.4 (be careful when merging) | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #32542 | License | MIT Now the parameter cache_dir of Translator constructor can be change or disable on config ```yaml #framework.yaml framework: ... translator: cache_dir: null #(cache disable) ... ``` Commits ------- 7613c7d [FrameworkBundle] add config translator cache_dir
This was referenced Nov 12, 2019
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the parameter cache_dir of Translator constructor can be change or disable on config